Reduce overhead of Swift runtime initialization for YYJSONDecoder#10
Draft
mattt wants to merge 2 commits into
Draft
Reduce overhead of Swift runtime initialization for YYJSONDecoder#10mattt wants to merge 2 commits into
YYJSONDecoder#10mattt wants to merge 2 commits into
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve the significant cold start delay of
YYJSONDecodercompared to FoundationJSONDecoderobserved by @zshannon in #9.Throwing spaghetti at the wall to see what sticks:
_YYDecoderConfigclass to share strategy configuration across all nested decoders and containers. This should help a lot for deeply nested JSON.YYJSONDecoder.warmup(for:)method gives API consumers an explicit way to amortize those startup costs on their own terms.Other things we can try:
@inlinable+@usableFromInlineto allow for cross-module inlining and avoiding witness table lookups@inline(__always)to similar effect@frozen, which eliminates runtime metadata by fixing ABI layout at compile time