Skip to content

Fix project board scroll confinement in workspace panes#15

Merged
matfire merged 1 commit intomainfrom
fix/panel-scroll-behavior
Mar 25, 2026
Merged

Fix project board scroll confinement in workspace panes#15
matfire merged 1 commit intomainfrom
fix/panel-scroll-behavior

Conversation

@matfire
Copy link
Copy Markdown
Member

@matfire matfire commented Mar 25, 2026

Summary

  • remove vertical scrolling from the outer workspace inset so scroll stays within the board area
  • replace the fixed pane body height calculation with a constrained flex layout using min-h-0
  • preserve the existing sticky workspace header while preventing the full pane from scrolling

Testing

  • Not run (not requested)

Summary by CodeRabbit

  • Style
    • Optimized workspace layout structure to improve container sizing and overflow behavior.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e0fa9130-97bb-477f-81e0-250f4a6d8498

📥 Commits

Reviewing files that changed from the base of the PR and between da03feb and 09df68b.

📒 Files selected for processing (1)
  • src/components/projects-workspace/projects-workspace.tsx

📝 Walkthrough

Walkthrough

A single layout file was modified to improve container height and overflow behavior in a workspace shell component by applying min-h-0 constraints and flexible sizing to flex containers, replacing fixed-height calculations.

Changes

Cohort / File(s) Summary
Layout Container Constraints
src/components/projects-workspace/projects-workspace.tsx
Updated CSS classes on SidebarInset, main section, and inner wrapper div to improve flex container behavior: replaced fixed-height calculations with min-h-0 flex-1 overflow-hidden, and adjusted overflow properties for consistent layout.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With min-h-0 and flex-1 dance,
The containers now have breathing chance!
No more height calculations tight,
The workspace shell flexes just right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing scroll behavior in workspace panes by confining it to the project board, which aligns with the file changes and PR objectives.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/panel-scroll-behavior

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@matfire matfire merged commit c0c86d7 into main Mar 25, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant