Fix ClearSign UTF-8 encoding corruption#321
Merged
mattosaurus merged 5 commits intomasterfrom Jan 13, 2026
Merged
Conversation
Co-authored-by: mattosaurus <22458485+mattosaurus@users.noreply.github.com>
Co-authored-by: mattosaurus <22458485+mattosaurus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Clearsign method encoding to retain UTF8 content
Fix ClearSign UTF-8 encoding corruption
Dec 17, 2025
Owner
|
@copilot update to also add tests for the sync and async stream and file methods in addition to the existing string tests for verifying the encoding. |
Co-authored-by: mattosaurus <22458485+mattosaurus@users.noreply.github.com>
Contributor
Author
Added UTF-8 encoding tests for all ClearSign method variants (file and stream, both sync and async). All 18 new tests pass successfully. Commit: 5e10e01 |
|
This was referenced Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The
ClearSignmethods were using ASCII encoding to convert text to bytes, corrupting non-ASCII characters (š → ?, € → ?, 中文 → ???).Changes
OutputClearSignedandOutputClearSignedAsync: ChangedEncoding.ASCII.GetBytes()toEncoding.UTF8.GetBytes()for line content conversionExample
The change affects only the encoding step in clear-signing; signature generation and verification remain unchanged.
Testing
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.