FIX: make word emphasis readable on light themes#19
Open
syabro wants to merge 1 commit into
Open
Conversation
Use lighter word-emphasis backgrounds when the configured Shiki theme is light, keep existing dark-theme background colors, and remove the forced bold style from word emphasis. Add and update regression tests for the rendered emphasis sequences.
syabro
force-pushed
the
fix/theme-aware-word-emphasis
branch
from
f3c5514 to
bfa2cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use lighter word-emphasis backgrounds to fix "black text on dark bg" when the configured Shiki theme is light, keeping the existing dark-theme colors unchanged. Add a regression test for the light-theme highlight colors.
Before:
after
