[Feature] PALM Serializer (rebased from PR #191) by Copilot · Pull Request #2 · matthew-mccall/Oasis

Copilot · 2026-04-18T17:05:48Z

Fetched PR Feature palm serializer open-algebra/Oasis#191 branch (feature-palm-serializer from CodingPupper3033/Oasis)
Created new branch from latest origin/master
Rebased all 30 commits from PR Feature palm serializer open-algebra/Oasis#191 onto origin/master
Resolved 2 merge conflicts in cmake/FetchBoost.cmake (keeping both bimap/assign additions and the BOOST_ENABLE_COMPATIBILITY_TARGETS ON from master)
Fixed clang-format violations in io/src/PALMSerializer.cpp, io/src/FromPALM.cpp, io/include/Oasis/PALMSerializer.hpp, io/include/Oasis/FromPALM.hpp
Fixed include guard name mismatch in io/src/PALMHelper.hpp (was OASIS_PALMCONST_HPP, now OASIS_PALMHELPER_HPP)
Push rebased branch and create PR
Validated: CodeQL found 0 security alerts, code review passed
Verify CI checks pass (workflows awaiting maintainer approval)

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…lization tests Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…plement serialization for Log, Negate, Derivative, Integral, and Magnitude Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…miters Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

… PALMSerializer Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…nversion Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…pping Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…odify PALMHelper.hpp to define TokenBimap for expression type mapping Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…OASIS_BUILD_JS Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

… by type (operators and delimiters). Also refactored the helper functions to use the new feature. Also split the separators between the start/end parenthesis and between operands into two separate delimiters (so in the future we could do something like (+ 5 2) instead of needing to be ( + 5 2 ) Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

….hpp Created PALMTokenizer to tokenize the input string. (By whitespace or punctuators) Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…e (LeafExpression, BinaryExpression, UnaryExpression). Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…to PALMTokenizer Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…zation error types, and refactor WrapExpression parameters Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…onsistency in naming, and enhanced error handling Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…n operand handling Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Agent-Logs-Url: https://github.com/matthew-mccall/Oasis/sessions/4f16a3f8-7c2c-40f8-9b54-f740a9748c3e Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

…nt `TypedVisit` support for `Sine`, and refactor Boost usage in CMake.

Copilot AI assigned Copilot and matthew-mccall Apr 18, 2026

Copilot created this pull request from a session on behalf of matthew-mccall April 18, 2026 17:10 View session

Copilot AI requested a review from matthew-mccall April 18, 2026 17:10

Copilot finished work on behalf of matthew-mccall April 18, 2026 17:10

CodingPupper3033 and others added 25 commits June 6, 2026 16:41

Add PALMSerializer and related constants for expression serialization

a754a69

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactor PALMOpts and enhance PALMSerializer with comprehensive seria…

2a57980

…lization tests Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Enhance PALMSerializer with support for additional expressions and im…

f0eab2b

…plement serialization for Log, Negate, Derivative, Integral, and Magnitude Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactor PALMDelimiters to use static string_view for expression deli…

9a68614

…miters Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Add tests for malformed expressions in PALMSerializer

637008c

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Add PALMHelper for expression token conversion and update includes in…

134f10f

… PALMSerializer Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactor PALMHelper to use maps for expression and delimiter token co…

26de113

…nversion Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Add TODO comment for Matrix serialization in PALMSerializer

75ef0d3

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

[Actions] Format CMakeLists.txt

95297af

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Add Boost Bimap includes and define TokenBimap for expression type ma…

e7cf968

…pping Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Update PALMDelimiterToToken to remove unused options parameter

a3d746d

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Update FetchBoost.cmake to include 'bimap' in BOOST_INCLUDE_LIBRARIES

387ff30

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactor PALMSerializer to improve code formatting and readability

e6f2ac8

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Update CMakeLists.txt to link Boost Bimap and adjust include directories

56d017d

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Update CMakeLists.txt and FetchBoost.cmake to include Boost Assign; m…

aef713c

…odify PALMHelper.hpp to define TokenBimap for expression type mapping Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Update CMakeLists.txt to conditionally link Boost libraries based on …

65e8bb5

…OASIS_BUILD_JS Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

[Actions] Format CMakeLists.txt

ae13938

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Clang Format

587abcf

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Split PALMHelper.hpp into PALMTypes.hpp, PALMConsts.hpp, and PALMSpec…

9de6c7f

….hpp Created PALMTokenizer to tokenize the input string. (By whitespace or punctuators) Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactored PalmSerializer to use PALMSpec

4c3385e

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactored PalmSerializer to SerializeExpression by the parameter typ…

fac63bb

…e (LeafExpression, BinaryExpression, UnaryExpression). Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Clang Formatted

6c5a5d1

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Removed PALMSpec and moved functions (which were tokenizer specific) …

a135677

…to PALMTokenizer Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactor parsing error handling to use new error types and structures

41fe6c7

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

CodingPupper3033 and others added 8 commits June 6, 2026 16:41

Refactor FromPALM functions and enhance error handling in PALM parsing

212b2fe

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Enhance error handling in FromPALM and PALMSerializer, update seriali…

a236125

…zation error types, and refactor WrapExpression parameters Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactor PALM serialization and parsing tests for improved clarity, c…

fb4e1ee

…onsistency in naming, and enhanced error handling Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Refactor error types in FromPALM to improve clarity and consistency i…

65649c5

…n operand handling Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Add InvalidOperator error type to FromPALM and enhance parsing logic

d59ca93

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

[Actions] Run clang-format

ba3fb5b

Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Fix include guard name in PALMHelper.hpp

51a62fc

Agent-Logs-Url: https://github.com/matthew-mccall/Oasis/sessions/4f16a3f8-7c2c-40f8-9b54-f740a9748c3e Co-authored-by: matthew-mccall <46231996+matthew-mccall@users.noreply.github.com>

Add LeafExpression and DerivedFromLeafExpression concept, impleme…

48a2774

…nt `TypedVisit` support for `Sine`, and refactor Boost usage in CMake.

matthew-mccall force-pushed the copilot/rebase-stale-pr-on-master branch from 621abf4 to 48a2774 Compare June 6, 2026 20:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] PALM Serializer (rebased from PR #191)#2

[Feature] PALM Serializer (rebased from PR #191)#2
Copilot wants to merge 33 commits into
masterfrom
copilot/rebase-stale-pr-on-master

Copilot AI commented Apr 18, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 18, 2026 •

edited

Loading