build(deps): bump @types/node to ^26.0.0#3996
Merged
Merged
Conversation
Adapt NodeJsCryptoTest to @types/node 26 dropping KeyObject from the createPublicKey overload by deriving the public key via PEM export. Supersedes #3953. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Apollon77
added
the
automerge
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Node.js TypeScript typings to @types/node@^26 and adjusts a Node.js crypto unit test to remain type-correct under the updated createPublicKey typings.
Changes:
- Bump
@types/nodeto^26.0.0in packages that declare it (create,react-native,testing). - Update
NodeJsCryptoTestto derive the public key from a PEM export of the private key (avoids passing aKeyObjectdirectly). - Refresh
package-lock.json(includes updates beyond@types/node).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/testing/package.json | Bumps @types/node to ^26.0.0 for the testing package. |
| packages/react-native/package.json | Bumps @types/node to ^26.0.0 for the React Native package. |
| packages/create/package.json | Bumps @types/node to ^26.0.0 for the create package. |
| packages/nodejs/test/crypto/NodeJsCryptoTest.ts | Adjusts crypto test to align with updated Node typings for createPublicKey. |
| package-lock.json | Updates lockfile to reflect the dependency changes (and additional transitive upgrades). |
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@types/nodefrom^25.9.xto^26.0.0across all packages that declare it (create,react-native,testing).Supersedes #3953 (Dependabot) — that PR only touched the lockfile and broke type checking.
Typing fix
@types/node 26 dropped
KeyObjectfrom thecreatePublicKeyoverload (nowBinaryLikeonly).NodeJsCryptoTestpassed a privateKeyObjectdirectly; runtime still supports it but type check failed. Fixed type-clean by deriving the public key via PEM export of the private key — no cast.Verification
packages/nodejsesm tests 307/307 (incl. sec1/spki crypto test)🤖 Generated with Claude Code