Skip to content

fix(protocol): drop stack traces from DCL error logs#3992

Merged
mergify[bot] merged 1 commit into
mainfrom
fix/dcl-error-log-no-stacktrace
Jun 26, 2026
Merged

fix(protocol): drop stack traces from DCL error logs#3992
mergify[bot] merged 1 commit into
mainfrom
fix/dcl-error-log-no-stacktrace

Conversation

@Apollon77

Copy link
Copy Markdown
Collaborator

Summary

DCL download/update errors logged the full error object, dumping multi-line stack traces for routine transient failures (e.g. DCL timeouts). Now they log the message + cause chain via Diagnostic.errorMessage, no stack.

Before:

INFO DclVendorInfoService Error updating vendor information [dcl-response] Error fetching /dcl/vendorinfo/vendors from DCL: 500 - The operation was aborted due to timeout
    at DclClient.#fetchJson (.../DclClient.ts:97:19)
    at async DclClient.#fetchPaginatedJson (.../DclClient.ts:63:30)
    ... (full stack)
  Caused by: The operation was aborted due to timeout

After:

INFO DclVendorInfoService Error updating vendor information [dcl-response] Error fetching /dcl/vendorinfo/vendors from DCL: 500 - The operation was aborted due to timeout: The operation was aborted due to timeout

Changes

  • DclVendorInfoService.ts — vendor-info update failure
  • DclOtaUpdateService.ts — OTA image validation/re-download + OTA file read failures

🤖 Generated with Claude Code

Log message + cause chain via Diagnostic.errorMessage instead of the
full error object for vendor-info update, OTA image validation, and OTA
file read failures.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 26, 2026 14:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise in the DCL (Distributed Compliance Ledger) integration by avoiding multi-line stack traces for routine/transient failures, logging a concise message plus the cause chain via Diagnostic.errorMessage(...) instead.

Changes:

  • Update DclVendorInfoService to log vendor update failures using Diagnostic.errorMessage(asError(error)) instead of logging the raw error object.
  • Update DclOtaUpdateService to log OTA validation/re-download and OTA file read failures using Diagnostic.errorMessage(asError(error)) (and add the needed asError import).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/protocol/src/dcl/DclVendorInfoService.ts Replace raw error logging with Diagnostic.errorMessage(asError(...)) for vendor update failures to avoid stack traces.
packages/protocol/src/dcl/DclOtaUpdateService.ts Replace raw error logging with Diagnostic.errorMessage(asError(...)) for OTA validation and OTA file read failures; add asError import.

Comment thread packages/protocol/src/dcl/DclVendorInfoService.ts
@Apollon77 Apollon77 added the automerge Set this label if the PR is ready to automatically merged after approval label Jun 26, 2026
@mergify

mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mergify mergify Bot merged commit 9bf206f into main Jun 26, 2026
44 checks passed
@mergify mergify Bot deleted the fix/dcl-error-log-no-stacktrace branch June 26, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Set this label if the PR is ready to automatically merged after approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants