Node Manager Phase 2a-2: acl ItemKind, verify pass & engine hardening#3954
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…rity bands Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ng, dispose race Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ting Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ard test Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… tradeoff Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
… unread Pre-flight admission stays meaningful instead of failing open; the device write remains the authoritative gate for over-capacity (RESOURCE_EXHAUSTED). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-PR into
node-manager(umbrella PR #3948 picks it up in CI). Phase 2a-2 makes the 2a-1 reconciler engine real end-to-end with the first concrete ItemKind.What's in it
planActions):reconcile(verify:true)== JFDSRefreshNode.convergere-checked only on explicit verify;maintainauto-verifies on periodic passes.ItemKind.verify?()added to the@matter/nodeTier-1 interface — kinds own device read + match; engine buildsdriftedKeysfromfalseresults.aclItemKind (@matter/node-manager): per-entry intent, additive coexistence (never removes foreign/admin entries; appends our exact entry only when not covered;OMIT_FABRICwrites), per-(subject × target)-cell subsumption verify (tolerates device-side compression/split), capacity =accessControlEntriesPerFabric. Reads fabric-filtered. Compression deferred to Phase 4 (Tier-3 optimizer).aclauto-registration + publicregisterItemKind().InFlightGuard), Add build and test before merging to main #5 start-after-dispose guard.docs/LOGGING.md-conformant; steady state quiet).keyset/group/membership/acl, acl last).@matter/node/testing(MockSite/MockServerNode/MockExchange/node-helpers), so@matter/node-manager(and future phases) can commission peers in tests. 65 node test files repointed.ReconcilerBehavior.early = trueso it initializes before subscription/peer events (matchesNetworkBehavior/CommissioningClient).Tests
AclCapacityExceededError; mutate ACL behind the engine → verify re-pends + re-applies.build --clean,format-verify,lintgreen;@matter/node-manager40/40;@matter/node1223/1223.Review
Whole-branch opus review: merge-ready, zero Critical/Important. ACL subsumption verified to have no false-positive (security-relevant direction); admin-ACL clobber-safety confirmed.
🤖 Generated with Claude Code