fix: refined Promise detection logic to account for alternate implementations#5
Open
emeraldsanto wants to merge 1 commit intomainfrom
Open
fix: refined Promise detection logic to account for alternate implementations#5emeraldsanto wants to merge 1 commit intomainfrom
Promise detection logic to account for alternate implementations#5emeraldsanto wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix bugs when using this library with third-party modules which either wrap the native
Promiseobject or declare alternative implementations altogether. Due to the way we currently handlePromisedetection, the latter case would fail that check and be treated as a synchronous value and unexpectedly throw instead of being handled bydoublet.See https://stackoverflow.com/a/27746324
Type of change
Please delete options that are not relevant.
Test Configuration:
Checklist: