Possible cmake improvements#1
Open
raymondEhlers wants to merge 2 commits into
Open
Conversation
From https://scikit-build-core.readthedocs.io/en/latest/faqs.html#finding-python, including the `Embed` module (which is implied by `Development`) is often note needed. However, cppyy may reintroduce this requirement - I'm not sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempting to install and run
heppyyon hiccup and ran into a few small issues. I usepyenvfor managing python installations - it tends to be a bit more troublesome than standard python installs, but allows for more customization. The changes needed to support it are:find_pythonapproach. Otherwise, it doesn't find my installation. Note that you can always install cmake from pypi if the native one is too old.find_python. Per here, this should be enough. I'm not sure if cppyy has stricter requirements, but I was able to compile and testheppyywithout error using this approach, so it seems okay as a baseline. I didn't test extensively what this difference implies, so feel free to drop this one (I think 1 is worth keeping because it shouldn't cost anything)