Open
Conversation
Member
|
Hi @Gustaf-C , thank you for finding and working to resolve this issue! |
dklilley
requested changes
Mar 24, 2026
| <string>Handle things like arg = val; nextArg</string> | ||
| <key>match</key> | ||
| <string>(=[^;]*)</string> | ||
| <string>(=(?:[^\[;]+|\[[^\]]*\])*)</string> |
Member
There was a problem hiding this comment.
Overall this change looks good for handling this case!
I believe there is also an issue with cell arrays in the same scenario:
classdef Foo
properties
cellArr = {1 1; 2 2};
end
endCould you make a quick addition to include this case as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the incorrect highligting of matrices, shown below:
In essence it changes the validation to ignore a semicolon if it is enclosed in brackets.
As a small addition I added a print that tells you that all tests passed.
Closes #101