Copilot/dependabot merge requests

[mathun3003]

This pull request primarily updates dependencies and refactors the GoodreadsSpider and AZQuotesSpider spiders to improve code robustness and clarity. The most significant changes are grouped below:

Dependency Updates:

• Updated key dependencies in pyproject.toml, including scrapy to 2.14.2, pytest to 9.0.3, and black to 26.3.1, ensuring compatibility with the latest features and bug fixes. [1] [2]

Refactoring and Robustness Improvements in Spiders:

• Removed unused Any import from both azquotes_spider.py and goodreads_spider.py for cleaner type imports. [1] [2]
• Simplified the parse method signatures in both spiders by removing unnecessary **kwargs and updating return types for clarity and correctness. [1] [2]
• In GoodreadsSpider, improved error handling in parse_subpage by adding explicit checks for missing elements (likes text, author, author profile, quote text) and raising ValueError with clear messages when data is missing. [1] [2]
• Refactored the construction of the QuoteItem in parse_subpage for better readability and to avoid repeated code by extracting and validating fields before use.

[Copilot]

Pull request overview

This PR updates core scraping/tooling dependencies and refactors the Goodreads and AZQuotes spiders to tighten parsing behavior and improve robustness when expected page elements are missing.

Changes:

• Bumped key dependencies in pyproject.toml (notably Scrapy/Black/Pytest).
• Refined GoodreadsSpider parsing flow and added explicit missing-element checks before constructing scraped items.
• Simplified spider parse method signatures by removing unused **kwargs (and related unused imports).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 12 comments.

File	Description
pyproject.toml	Updates Scrapy/Black/Pytest versions used by the app and CI tooling.
quotes_recommender/quote_scraper/spiders/goodreads_spider.py	Tightens parse/subpage parsing and adds explicit validations before item construction.
quotes_recommender/quote_scraper/spiders/azquotes_spider.py	Removes unused typing import and simplifies parse signature.

Comments suppressed due to low confidence (3)

quotes_recommender/quote_scraper/spiders/goodreads_spider.py:86

• After extracting likes with re.findall(...), the code indexes num_likes_list[0] without handling the case where the regex finds no numbers. This will raise an IndexError instead of a clear error when likes text is present but doesn't contain a number.

        num_likes_list: list[str] = re.findall(self.NUM_LIKES_REGEX, likes_text)
        if len(num_likes_list) > 1:
            raise StopDownload(fail=True)
        if not num_likes_list[0].isdigit():
            raise ValueError('num_likes is not a digit. Failed to convert to int.')

quotes_recommender/quote_scraper/spiders/goodreads_spider.py:86

• After extracting likes with re.findall(...), the code indexes num_likes_list[0] without handling the case where the regex finds no numbers. This will raise an IndexError instead of a clear error when likes text is present but doesn't contain a number.

        num_likes_list: list[str] = re.findall(self.NUM_LIKES_REGEX, likes_text)
        if len(num_likes_list) > 1:
            raise StopDownload(fail=True)
        if not num_likes_list[0].isdigit():
            raise ValueError('num_likes is not a digit. Failed to convert to int.')

quotes_recommender/quote_scraper/spiders/goodreads_spider.py:86

• After extracting likes with re.findall(...), the code indexes num_likes_list[0] without handling the case where the regex finds no numbers. This will raise an IndexError instead of a clear error when likes text is present but doesn't contain a number.

        num_likes_list: list[str] = re.findall(self.NUM_LIKES_REGEX, likes_text)
        if len(num_likes_list) > 1:
            raise StopDownload(fail=True)
        if not num_likes_list[0].isdigit():
            raise ValueError('num_likes is not a digit. Failed to convert to int.')

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mathun3003]

@copilot fix the three failed code style checks. Fix the black and pylint linting errors. Also fix the mypy typing errors.