chore(deploy): Gate hosted SQLite recovery behind explicit flag #31 by mathemage · Pull Request #32 · mathemage/deep-workflow

mathemage · 2026-04-18T00:31:02Z

Summary

require an explicit DJANGO_ENABLE_HOSTED_SQLITE_FALLBACK=1 opt-in before hosted SQLite recovery activates
keep normal hosted deployments fail-fast when DATABASE_URL is missing or invalid
document the emergency-only recovery mode and add regression coverage around the flag

Why

The SQLite rescue path is useful during an outage, but it should never activate silently during normal hosted deploys. This PR keeps the recovery option available while making it a deliberate operator choice.

Closes #31

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vercel · 2026-04-18T00:31:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
deep-workflow	Error		Apr 19, 2026 5:35pm

Copilot

Pull request overview

This PR makes the hosted “SQLite recovery” behavior an explicit operator opt-in by introducing DJANGO_ENABLE_HOSTED_SQLITE_FALLBACK, and documents/tests the intended emergency-only workflow for Vercel-hosted deployments.

Changes:

Add DJANGO_ENABLE_HOSTED_SQLITE_FALLBACK and compute HOSTED_SQLITE_FALLBACK to gate cookie-backed sessions/messages in hosted + SQLite mode.
Add regression tests asserting the hosted SQLite fallback is off by default and only activates when explicitly enabled.
Document the emergency hosted SQLite recovery mode and the new environment variable.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`deep_workflow/settings.py`	Introduces `DJANGO_ENABLE_HOSTED_SQLITE_FALLBACK` and gates cookie-backed session/message backends behind a hosted+SQLite+flag condition.
`core/tests/test_deployment.py`	Adds subprocess-based tests to validate the new flag behavior in settings import-time logic.
`README.md`	Documents the emergency-only flag and explains when/how to use hosted SQLite recovery.

mathemage · 2026-04-18T00:38:09Z

@copilot apply changes based on the comments in this thread

Resolve all discussions at #32 (review) when each comment is tackled.

Agent-Logs-Url: https://github.com/mathemage/deep-workflow/sessions/443c7d6a-3fb6-46e8-afcf-bf5946cd691a Co-authored-by: mathemage <3373514+mathemage@users.noreply.github.com>

…holder DB creds Agent-Logs-Url: https://github.com/mathemage/deep-workflow/sessions/443c7d6a-3fb6-46e8-afcf-bf5946cd691a Co-authored-by: mathemage <3373514+mathemage@users.noreply.github.com>

Copilot · 2026-04-18T00:44:03Z

@copilot apply changes based on the comments in this thread

Resolve all discussions at https://g...

All 4 review discussions addressed in commits 36cf212 and f90ebe3:

settings.py — added fail-fast ImproperlyConfigured raise when HOSTED_ENV is true and DB engine is SQLite but HOSTED_SQLITE_FALLBACK is false, so normal hosted deploys can never silently use SQLite.
test_deployment.py (143-149) — load_hosted_settings() now emits native JSON booleans instead of str(bool), return type updated to tuple[bool, str, str], and assertions use is True / is False.
test_deployment.py (172-179) — test_hosted_sqlite_fallback_is_disabled_by_default now expects subprocess failure (ImproperlyConfigured in stderr, non-zero exit code); added test_hosted_sqlite_fallback_flag_ignored_for_postgresql asserting HOSTED_SQLITE_FALLBACK stays False and session/message backends are unchanged when DATABASE_URL is PostgreSQL.
README.md (189) — expanded the emergency recovery note with the cookie size and signed-cookie readability warning.

Helper also renamed from load_hosted_sqlite_settings → load_hosted_settings since it now covers both SQLite and PostgreSQL URLs.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

mathemage · 2026-04-18T22:09:39Z

@copilot apply changes based on the comments in this thread

Resolve discussion at #32 (review) once each comment is fixed

…flag Agent-Logs-Url: https://github.com/mathemage/deep-workflow/sessions/849021ef-a502-4f93-918d-5088bc04d46c Co-authored-by: mathemage <3373514+mathemage@users.noreply.github.com>

Copilot · 2026-04-18T22:12:39Z

@copilot apply changes based on the comments in this thread

Resolve discussion at https://github.com/mathe...

Fixed in 6815141.

The hosted SQLite guard message now explicitly says hosted deploys require a valid PostgreSQL DATABASE_URL unless the emergency fallback flag is enabled. The failure regression test now asserts on that specific message content, and there is a new test covering the default-disabled behavior when DJANGO_ENABLE_HOSTED_SQLITE_FALLBACK is unset.

Validation passed with ruff check ., ruff format --check ., python manage.py check, pytest, and final review/security validation.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

(1) PostgreSQL `DATABASE_URL`, or (2) `DJANGO_ENABLE_HOSTED_SQLITE_FALLBACK=1` + a SQLite `DATABASE_URL` (emergency only) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

chore(deploy): Gate hosted SQLite recovery behind explicit flag #31

6e59530

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 18, 2026 00:31

vercel Bot had a problem deploying to Preview April 18, 2026 00:31 Failure

Copilot started reviewing on behalf of mathemage April 18, 2026 00:31 View session

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread deep_workflow/settings.py

Comment thread core/tests/test_deployment.py Outdated

Comment thread core/tests/test_deployment.py

Comment thread README.md Outdated

Copilot started work on behalf of mathemage April 18, 2026 00:38 View session

fix(deploy): Address PR review feedback on hosted SQLite fallback gating

36cf212

Agent-Logs-Url: https://github.com/mathemage/deep-workflow/sessions/443c7d6a-3fb6-46e8-afcf-bf5946cd691a Co-authored-by: mathemage <3373514+mathemage@users.noreply.github.com>

vercel Bot had a problem deploying to Preview April 18, 2026 00:42 Failure

refactor(deploy): Rename helper to load_hosted_settings and use place…

f90ebe3

…holder DB creds Agent-Logs-Url: https://github.com/mathemage/deep-workflow/sessions/443c7d6a-3fb6-46e8-afcf-bf5946cd691a Co-authored-by: mathemage <3373514+mathemage@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 18, 2026 00:43

mathemage removed the request for review from Copilot April 18, 2026 00:43

vercel Bot had a problem deploying to Preview April 18, 2026 00:44 Failure

Copilot finished work on behalf of mathemage April 18, 2026 00:44

mathemage requested a review from Copilot April 18, 2026 22:04

mathemage added this to the chore(deploy): Prepare production deployment, backups, and monitoring milestone Apr 18, 2026

Copilot started reviewing on behalf of mathemage April 18, 2026 22:05 View session

mathemage added the bug Something isn't working label Apr 18, 2026

mathemage self-assigned this Apr 18, 2026

Copilot AI reviewed Apr 18, 2026

View reviewed changes

Comment thread core/tests/test_deployment.py

Comment thread core/tests/test_deployment.py Outdated

Comment thread deep_workflow/settings.py Outdated

Copilot started work on behalf of mathemage April 18, 2026 22:09 View session

test(deploy): Tighten hosted SQLite guard assertions and cover unset …

6815141

…flag Agent-Logs-Url: https://github.com/mathemage/deep-workflow/sessions/849021ef-a502-4f93-918d-5088bc04d46c Co-authored-by: mathemage <3373514+mathemage@users.noreply.github.com>

vercel Bot had a problem deploying to Preview April 18, 2026 22:11 Failure

Copilot finished work on behalf of mathemage April 18, 2026 22:13

mathemage requested a review from Copilot April 18, 2026 22:19

Copilot started reviewing on behalf of mathemage April 18, 2026 22:20 View session

mathemage requested a review from Copilot April 19, 2026 16:26

Copilot started reviewing on behalf of mathemage April 19, 2026 16:26 View session