netspeed: avoid glibtop warnings for non-existent network devices#689
Merged
Conversation
When a network interface is disabled at the kernel level, the applet tries to read from a device that no longer exist, generating continuous warning messages in syslog. Check if the device exists before calling glibtop_get_netload in both is_dummy_device and get_device_info. When the device doesn't exist, get_device_info returns a non-running device info, allowing the existing auto-change logic to find an active device. Fixes #688
vkareh
force-pushed
the
netspeed-missing-device-warnings
branch
from
5cd424c to
2be3597
Compare
mbkma
approved these changes
May 27, 2026
Member
mbkma
left a comment
mbkma
left a comment
There was a problem hiding this comment.
Good defensive fix. Checking that the interface still exists before asking glibtop for netload data should avoid the warning spam when a device disappears, and falling back to the non-running path keeps the auto-change logic working the way it already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a network interface is disabled at the kernel level, the applet tries to read from a device that no longer exist, generating continuous warning messages in syslog.
Check if the device exists before calling glibtop_get_netload in both is_dummy_device and get_device_info. When the device doesn't exist, get_device_info returns a non-running device info, allowing the existing auto-change logic to find an active device.
Fixes #688