Skip to content

added sorted_variables#3599

Open
DanZhul wants to merge 5 commits into
mate-academy:masterfrom
DanZhul:develop
Open

added sorted_variables#3599
DanZhul wants to merge 5 commits into
mate-academy:masterfrom
DanZhul:develop

Conversation

@DanZhul

@DanZhul DanZhul commented Jun 18, 2026

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution because it meets all of the core task requirements: you defined exactly eight variables of different data types and correctly grouped them into the sorted_variables dictionary with the required keys `


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because a core requirement of the task is currently broken and the solution does not match the expected final structure. You initially build sorted_variables correctly with all eight variables, but then you reassign sorted_variables to {"mutable": [], "immutable": []} in app/main.py, which wipes out the correct grouping and violates [CHECKLIST ITEM #2] and [CHECKLIST ITEM #3]. To fix this, remove the second assignment so that the original sorted_variables dictionary (with the three mutable variables in "mutable" and the five immutable variables in "immutable") remains as the final value. In addition, the extra is_immutable function that mutates sorted_variables at runtime is unnecessary for this task and contradicts the requirement for a simple, static dictionary built from the main-module variables; please remove this function or at least stop it from modifying sorted_variables. Once those critical issues are fixed, you will have a clean, static sorted_variables dictionary that fully meets the task requirements; the remaining flake8 style issues (blank lines and type hints) are minor and can be resolved by following the linter’s suggestions. You did well defining the eight variables and the initial dictionary correctly—after these adjustments, your solution will be in great shape.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread app/main.py
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
@DanZhul

DanZhul commented Jun 18, 2026

Copy link
Copy Markdown
Author

fixed all

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved based on the current implementation. You correctly defined exactly eight variables of different data types in app/main.py, and you clearly separated mutable objects (my_favourite_films, marks, collection_of_coins) from immutable ones (lucky_number, pi, one_is_a_prime_number, name, profile_info). The sorted_variables dictionary is a static literal with exactly the keys "mutable" and "immutable", and each value is a list containing the actual variables, not their names or copies, which matches the task requirements. There is no reassignment or runtime mutation of sorted_variables, so the structure remains consistent and easy to reason about. Overall, the code is clean, straightforward, and fulfills the learning goals of distinguishing between mutable and immutable data types. Great work solidifying these core Python concepts while keeping the solution simple and correct.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants