Skip to content

Update main.py#3579

Open
milokc wants to merge 7 commits into
mate-academy:masterfrom
milokc:master
Open

Update main.py#3579
milokc wants to merge 7 commits into
mate-academy:masterfrom
milokc:master

Conversation

@milokc

@milokc milokc commented Jun 10, 2026

Copy link
Copy Markdown

deleted write your code here

deleted write your code here

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your submission is missing the core implementation required by the task. All 10 pytest tests are failing because the sorted_variables dictionary doesn't exist in app/main.py — the code only contains a placeholder comment where the implementation should be. You need to create a sorted_variables dictionary with two keys ("mutable" and "immutable"), and populate the corresponding lists with the 8 variables you already defined. Based on Python's standard library categorization, variables like name, my_favourite_films, profile_info, marks, and collection_of_coins should go in the "mutable" list, while lucky_number, pi, and one_is_a_prime_number belong in the "immutable" list. This is a fundamental requirement of the task, so the implementation must be added before your submission can be approved.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

milokc added 6 commits June 10, 2026 15:50
task complete
added set
changed names of variable
fixed line length and comments
finally got what to do

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly fulfills all task requirements. The sorted_variables dictionary has the proper structure with "mutable" and "immutable" keys, and all 8 variables are correctly categorized according to Python's standard type classifications (list, dict, set as mutable; int, float, bool, string, tuple as immutable). All requirements have been met, and the code is ready for use.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants