Skip to content

Develop#1997

Open
PatronXXi wants to merge 2 commits into
mate-academy:masterfrom
PatronXXi:develop
Open

Develop#1997
PatronXXi wants to merge 2 commits into
mate-academy:masterfrom
PatronXXi:develop

Conversation

@PatronXXi
Copy link
Copy Markdown

- [DEMO LINK](https://PatronXXi.github.io/js_task_parse_list_DOM/)

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all core task requirements. The sortList function correctly sorts employees by salary in descending order using salaryB - salaryA, and the getEmployees function properly extracts data from DOM data attributes and returns an array of employee objects with the required schema {name, position, salary, age}. Both functions are called appropriately with the employee list. The salary conversion helper works correctly. Minor suggestions: you could remove the unnecessary ESLint disable comment for cleaner code, and consider renaming the salaryReplace helper to something more descriptive like parseSalary for better readability. Overall, the solution is solid and functional.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants