Solution#1986
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation successfully meets all functional requirements. The sortList function correctly sorts employees by salary in descending order using data attributes, and getEmployees properly returns an array of employee objects with the required { name, position, salary, age } schema. Both functions are called as specified, and only main.js was modified as required. The README.md demo link issue mentioned in the review is a documentation/administrative item rather than a code functionality blocker, so it doesn't prevent approval. Minor suggestions for improvement: - The toSorted method is ES2023, which works in modern browsers but Array.prototype.sort() with a copy would offer broader compatibility - When extracting the name field, you might want to consider more precise selection if the HTML structure includes additional elements, to avoid potential whitespace issues. Overall, the core logic is solid and well-organized. Great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.