Skip to content

add task solution#1985

Open
h-rostyslav wants to merge 2 commits into
mate-academy:masterfrom
h-rostyslav:develop
Open

add task solution#1985
h-rostyslav wants to merge 2 commits into
mate-academy:masterfrom
h-rostyslav:develop

Conversation

@h-rostyslav
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly fulfills all the task requirements. Both sortList and getEmployees functions are properly implemented with correct signatures, data conversion, and sorting logic in descending order using getSalary(b) - getSalary(a). The employee object schema matches the specification with { name, position, salary, age } fields. There is one linting issue to address: an unused variable employees at line 36 in src/scripts/main.js. The linter will catch this and provide feedback, but you should remove or use this variable before final submission. All other aspects of your code are correct and meet the specifications. The core functionality is working as expected.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The implementation correctly fulfills all task requirements: the sortList function properly sorts employees by salary in descending order using getSalary(b) - getSalary(a), and the getEmployees function returns an array of employee objects with the required schema containing name, position, salary, and age fields. The helper function getSalary correctly converts salary strings to numbers using Number(), and both functions are called as expected. The previous issue with the unused variable has been resolved, and the code is clean and functional. All checklist items pass, and there are no critical blockers preventing task completion.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants