add task solution#1983
Open
Roma-Yamshchikov wants to merge 1 commit into
Open
Conversation
Roma-Yamshchikov
commented
May 3, 2026
Roma-Yamshchikov
commented
- DEMO LINK
mateacademy-ai-mentor
approved these changes
May 3, 2026
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is complete and meets all requirements. The sortList function correctly sorts list items by salary in descending order using dataset to access data attributes, and the getEmployees function returns properly formatted employee objects with name, position, salary, and age fields. The salary conversion helper function properly converts string salaries to numbers for accurate sorting. Both functions are called as specified, and only the main.js file was modified. No issues detected - great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.