Skip to content

add solution_js_task_parse_list_DOM#1982

Open
elenachernyshova01-cmd wants to merge 1 commit into
mate-academy:masterfrom
elenachernyshova01-cmd:develop
Open

add solution_js_task_parse_list_DOM#1982
elenachernyshova01-cmd wants to merge 1 commit into
mate-academy:masterfrom
elenachernyshova01-cmd:develop

Conversation

@elenachernyshova01-cmd
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your JavaScript implementation in src/scripts/main.js is complete and correct. Both required functions (sortList and getEmployees) are properly implemented with correct logic - sortList correctly sorts employee data in descending order by salary, and getEmployees returns properly structured employee objects with the required schema (name, position, salary, age). Your parseSalary helper function correctly handles the string-to-number conversion by stripping currency symbols and commas. The only remaining item is updating the GitHub Pages demo link in your README - replace https://<your_account>.github.io/ with your actual GitHub username. This is a documentation/deployment step rather than a code issue, and your core functionality is solid. Once you've updated the README with your live demo URL, your submission will be fully complete. Great work on implementing the sorting and data extraction logic correctly!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants