feat: parse list with data attributes

[linska]

No description provided.

[mateacademy-ai-mentor]

Review Summary

I am asking for some changes before this can be considered complete, because there are a couple of critical requirement and robustness issues remaining.

Critical issues to fix:

• In the repository, README.md was modified even though the task explicitly says to change only main.js; please revert any unintended README changes so that only src/scripts/main.js is altered for this task.
• In src/scripts/main.js, the helper function toNumber currently calls replaceAll directly on its argument, and both sortList and getEmployees pass values like a?.dataset?.salary and item?.dataset?.age, which can be undefined; this can throw a runtime TypeError when a dataset attribute is missing and does not meet the safe-conversion requirements [CHECKLIST ITEM #15][CHECKLIST ITEM #16]. To fix this, make toNumber tolerant of non-string input (e.g., by wrapping the argument with String(str ?? '') before calling replaceAll) so it always returns a valid number even when data attributes are absent.
• Near the bottom of main.js, you do const listElement = document.querySelector('ul') and immediately call sortList(listElement) and getEmployees(listElement); if the <ul> is not present, listElement will be null and these calls will throw, so please add a simple null check/guard before invoking these functions.

As minor (non-blocking) improvements, you might consider using a more specific selector than 'ul' and optionally capturing or exporting the result of getEmployees, but these are not required for acceptance. Your core logic for sorting the list and mapping employees looks good; once the above robustness and checklist-related issues are addressed, this solution will be in good shape.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

The helper toNumber assumes str is a string and calls replaceAll on it. If str is undefined/null this will throw. Make toNumber tolerant of non-string input (e.g. coerce with String(str ?? '') or use (str ?? '').replaceAll(...)) so it always returns a number as required by the checklist.

[mateacademy-ai-mentor]

Calling replaceAll directly on the incoming value can fail for non-strings. Consider using const num = Number(String(str ?? '').replaceAll(/[^0-9]/g, '')); to ensure safe conversion from dataset strings (satisfies checklist item #15 and #16).

[mateacademy-ai-mentor]

In sortList you use optional chaining and pass possibly undefined values to toNumber: toNumber(a?.dataset?.salary) and toNumber(b?.dataset?.salary). Either ensure toNumber handles undefined (recommended) or provide a default here (e.g. toNumber(a?.dataset?.salary ?? '')). This prevents runtime errors when a dataset entry is missing.

[mateacademy-ai-mentor]

Similarly, in getEmployees you call toNumber(item?.dataset?.salary) and toNumber(item?.dataset?.age). Ensure toNumber handles undefined or provide defaults here (e.g. toNumber(item?.dataset?.salary ?? '')) so the returned objects always contain numeric salary and age per the schema.

[mateacademy-ai-mentor]

You call document.querySelector('ul') and then immediately call sortList(listElement) and getEmployees(listElement) without checking if the element actually exists. Add a null-check (or guard) before calling these functions to avoid runtime errors when the list isn't present.

[mateacademy-ai-mentor]

Review Summary

This requires changes because, although your sortList and getEmployees implementations in src/scripts/main.js correctly satisfy the functional requirements (sorting by salary descending, parsing employee objects, and safely handling dataset values), you also modified README.md even though the task explicitly says that only src/scripts/main.js should be changed for this assignment. Changing README.md (in the section with the DEMO LINK near the top of the file) violates that constraint and can interfere with automated grading or consistency checks for the repository. Please revert README.md to its original state in this PR so that the only code changes come from src/scripts/main.js; if the demo link needs to be updated for a different step of the course, do that in the appropriate task where README edits are allowed. Once you revert that file, your JavaScript solution looks solid: it correctly uses data attributes, sorts in descending order by salary, converts strings to numbers robustly, and guards against a missing <ul> element. As a small, non-blocking improvement, consider using a more specific selector than document.querySelector('ul') and think about how the returned array from getEmployees might be exposed or used if tests rely on it. Overall, your core logic is well implemented; align the file changes with the task constraints and you should be in great shape.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[linska]

@mateacademy-ai-mentor README.md was not intentionally changed.

Those changes were introduced automatically by formatting tools during the commit process (likely Prettier adjusting commas and spacing). I did not edit this file manually, and it is not related to the task.

All required logic is implemented only in src/scripts/main.js, as specified in the instructions.

If necessary, I can try to revert the README.md file, but the formatting tools may apply the same changes again.

[mateacademy-ai-mentor]

Review Summary

Your solution is approved as an educational override so you can continue progressing while you address a couple of remaining issues. The JavaScript in src/scripts/main.js is well done: sortList correctly sorts by numeric salary in descending order, getEmployees returns objects with the required { name, position, salary, age } shape, and your toNumber helper safely converts salary strings to numbers. The main issue is that README.md has been modified in this PR, which violates the requirement that only src/scripts/main.js be changed and can interfere with automated grading [CHECKLIST ITEM #13]; in the diff view, every line of README.md shown as changed (with its line numbers) should be restored to exactly match the upstream main branch. To fix this, use one of the approaches you mentioned, such as git checkout origin/main -- README.md or git restore --source=origin/main README.md, then commit (using --no-verify if a formatter keeps reapplying changes). As a minor improvement, you could store or expose the result of getEmployees(listElement) (for example, assigning it to a variable or window.employees) so tests or other scripts can easily access the employee data [CHECKLIST ITEM #7]. Overall, your JavaScript meets the functional requirements nicely—once you revert the README changes and re-run the tests, your solution will be fully aligned with the task expectations.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Footnotes

1. Rate AI review example ↩