support rxjs 6 and only support version 5 and above#13
Open
juanferreira wants to merge 1 commit into
Open
Conversation
Author
|
Test seems not to be passing because var name in version 5 is Rx. However, in version 6 according to source code is rxjs. Not sure your test handles multiple var? |
Owner
|
Yeah, we would need to be able to override car in the versions object |
Author
|
FYI I was able to get the test to pass by making var null. Should I just do that instead? |
Owner
|
No, that wouldn't work. You wouldn't be able to call the library |
|
I have added the var support per URL and updated rxjs in #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RXJS 6 bundle names seem to have been renamed to rxjs.umd prefix.