Open
Conversation
…sTableTypos fix(Compendium): fix typos in Structure and Stress references
fix(Mech Sheet): temporarily hide duration chips for Core Systems
…ilotHP fix(Active Mode): fix pilot HP ticker during ActiveRest
…nergies feat(Mech Sheet): enable all synergies for "???" type weapons
This fix enforces the Quickstart options on the confirm page, properly disabling the "Register Pilot" button when missing mandatory fields.
This change overhauls the way we organize the pilot roster, storing group configuration in `pilot_groups.json`. This file tracks the Group Name, Hidden status, and list of Pilot IDs of pilots in the group. The groups themselves have become draggable, and their Hidden state is now persistent between visits to the Pilot Roster.
This change ensures persistent pilot combat stats between missions. It adds a visible stat record under Pilot Combat Telemetry Record on the Dossier tab of Pilot Management. This is an incredibly basic change; it could defintely stand to be improved upon in the future. Closes massif-press#1765
This change includes some redundant width settings for browsers that don't recognize `-webkit-fill-available`. The unrecognized options are subsequently ignored, so we are safe to add redundant `width` settings. Closes massif-press#1768
…Numbers style(Pilot Sheet): fix number spacing over icons in Print mode
…History feat(Pilot Sheet): add basic pilot stats to Dossier
…onfirmFix fix(Pilot Sheet): block pilot registration when quickstart is off
…Performance fix(Pilot Sheet): Refactor Pilot groups for performance & roster improvements
…ter improvements"
…x/pilotRosterPerformance Revert "fix(Pilot Sheet): Refactor Pilot groups for performance & roster improvements"
…ce & roster improvements""
This is a fix for the previous Pilot Group update. It disables the renewal of a new pilot ID upon calling `SetRemoteResource`, which led to ID mismatches between the Pilot Group structure and the Pilot itself. Weirdly enough, the Renewed ID was stored in the Pilot Group structure, while the Pilot's ID reverted back to the Pilot's CloudID. It's not clear why that reversion occurred, but it makes sense to me to keep the Pilot's ID the same as the CloudID instead of renewing it in these cases. Feedback/explanations for the contrary would be appreciated! This change also prevents importing pilots from the user's own account, as this leads to strange behavior when modifying/deleting the pilot. Better to prevent it in the first place. Also adds more informative error messages when a pilot ID is not found. Closes massif-press#1777
This fix removes the burn check from the "Start Round X" button, since Burn is only checked at the end of a player's turn. Closes massif-press#1774
…lter feat(Compendium): use AND filter on Frame role/mounts
Changed pilot button to go to tactical profile, commented out unused or
Issue massif-press#1847 - fix GetOrganized active mode
refactor(mech nav): pilot button to tactical profile, removed options
…Codes fix(pilot): roster remote refresh, error handling
Removed sections that aren't used any more due to being merged into
Updated reference to sheet in pilot management routes, deleted files
points to new location in tactical.
karidyas
force-pushed
the
combine_pilot_tabs
branch
from
6ccd18a to
a778346
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Combined Dossier and Narrative Profile into one tab, and Tactical Profile and Hangar into one tab to group concerns and cut down on necessary clicks.
Dossier is quite short but has some necessary functions in it like changing name and callsign. Hangar is equally short, so they were both good candidates.
Requesting pull into Dev as might need performance testing. It's fine on my machine (at least no worse than Live) but may have an impact on mobile and I don't know how to test that. If that wouldn't be possible I can change the location.
Type of change