refactor: Improve console logging control for Textual devtools#198
Merged
refactor: Improve console logging control for Textual devtools#198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📝 Summary
Refines the console logging configuration logic for the Textual TUI. When devtools mode is enabled, console logging remains active so
textual consolecan receive logs. In all other modes (including debug), console logging is disabled since the TUI hides it anyway, keeping only file-based logging.🔧 Changes Made
elif not debugtoelseblock🧪 Testing
titan-devpoetry run pytest)make test)Verified console logging behavior with and without devtools flag.
📊 Logs
✅ Checklist