refactor: eliminate 7 clone groups across services, bot, and web#36
Merged
Conversation
… report.service; extract getCategoryFromForm in category.actions
…d, replace SvelteURL with URL - stateGetters(...) spread evaluates getters as plain values at spread time, killing reactivity. Reverted to inline getters in both createTableState and createSimpleTableState so getter descriptors are preserved. - Added syncCount guard: the URL-watch was reverting programmatic filter changes because goto is async — the effect runs before the URL actually updates, reads the stale URL, and restores the old filter state. - Replaced SvelteURL with native URL in syncToURL to avoid any potential interference from SvelteURLSearchParams syncing back to the parent URL.
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Eliminated 7 of 9 clone groups (395→97 lines, 4.4%→1.1% duplication).
HIGH — report.service.ts
ticketDetailsWithconstant — sharedwithquery block betweengetTicketByIdandgetTicketByTicketCoderequireTicket(tx, id)— shared "find or throw" helper forupdateTicketStatusandupdateTicketPriorityHIGH — category.actions.server.ts
getCategoryFromForm(event)— shared form parsing + lookup fordeleteCategoryActionandtoggleCategoryActionMEDIUM — settings / categories pages
useCategoryDialog()Svelte 5 composable (.svelte.ts) — shared category CRUD dialog state betweensettings-categories-tab.svelteandcategories/+page.svelteLOW — table-state.svelte.ts
buildQuery(state),toggleSortInPlace(),hasSimpleFilters(),stateGetters()as module-level functions shared by bothcreateTableStateandcreateSimpleTableStateLOW — commands.ts (bot)
requireReporter(ctx)— shared registration check between/statusand/reporthandlersVerification
tsc --noEmitpasses for services, bot, websvelte-checkpasses with 0 errorsRemaining (intentionally skipped)
data-table.svelte/progressive-table.svelte(34 lines) — different configs, co-locatedagents-table.svelte/invite-codes-table.svelte(15 lines) — import block only