Skip to content

StyleX#932

Merged
martpie merged 8 commits intomasterfrom
stylex
Mar 4, 2026
Merged

StyleX#932
martpie merged 8 commits intomasterfrom
stylex

Conversation

@martpie
Copy link
Owner

@martpie martpie commented Mar 3, 2026

I kinda like it.

This branch is based on oxc as oxlint supports ESLint JS rules, which biome cannot do :(

Baseline:

martpie@martpie-mac museeks % npm run build      

> museeks@0.23.4 build
> vite build

vite v7.3.1 building client environment for production...
✓ 1329 modules transformed.
dist/index.html                   0.47 kB │ gzip:   0.32 kB
dist/assets/index-CRdrmV4Z.css   27.06 kB │ gzip:   5.68 kB
dist/assets/zh-CN-Cwo8ooWM.js     5.58 kB │ gzip:   2.94 kB
dist/assets/en-CVV0M9B2.js        5.60 kB │ gzip:   2.73 kB
dist/assets/zh-TW-BpA8INot.js     5.62 kB │ gzip:   2.94 kB
dist/assets/es-D7WRuUiI.js        6.19 kB │ gzip:   2.90 kB
dist/assets/fr-GGZI0hV2.js        6.74 kB │ gzip:   3.04 kB
dist/assets/ja-BxcwmR_m.js        7.44 kB │ gzip:   3.14 kB
dist/assets/ru-sNWmbzlo.js        9.24 kB │ gzip:   3.53 kB
dist/assets/index-qwUgm9vP.js   665.65 kB │ gzip: 216.19 kB

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 3.66s

Copilot AI review requested due to automatic review settings March 3, 2026 01:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces StyleX into the Vite/React frontend and updates repo tooling/config (lint/format + CI/editor settings), alongside some formatting-only changes and updated Lingui translation reference lines.

Changes:

  • Add StyleX (Vite plugin + StyleX runtime) and migrate Button from CSS modules/classnames to StyleX.
  • Switch lint/format tooling to oxlint/oxfmt and update CI + VS Code workspace recommendations/settings accordingly.
  • Reformat miscellaneous files and update .po source references.

Reviewed changes

Copilot reviewed 21 out of 24 changed files in this pull request and generated 17 comments.

Show a summary per file
File Description
vite.config.ts Adds @stylexjs/unplugin Vite plugin to enable StyleX transforms.
src/elements/Button.tsx Migrates styling from CSS modules to StyleX.
package.json Adds StyleX + oxc tooling deps; updates lint/format scripts and metadata ordering.
.oxlintrc.json Adds oxlint config, including StyleX ESLint rules via jsPlugins.
.oxfmtrc.json Adds oxfmt formatting configuration.
.github/workflows/build.yml Updates QA steps to run formatting + lint; adjusts matrix formatting.
.vscode/settings.json / .vscode/extensions.json Switches editor integration from Biome to oxc/oxfmt.
src/components/DropzoneImport.tsx Adjusts hook dependency array style.
src/components/TrackList.tsx Refactors menu items builder usage; adjusts effect dependencies.
src/hooks/useGlobalTrackListStatus.ts Adjusts effect dependency array style.
src/routes/settings.library.tsx Adjusts callback dependency array style.
src/__tests__/test-helpers.tsx Awaits render call (test harness).
src/translations/*.po Updates source references; includes new/changed strings (but see review comments).
index.html / README.md / src-tauri/Cargo.toml Formatting-only changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@martpie martpie force-pushed the stylex branch 4 times, most recently from 90ca890 to 1ae4d02 Compare March 3, 2026 02:00
@martpie martpie changed the base branch from master to oxc March 3, 2026 02:03
@martpie martpie changed the title Stylex StyleX Mar 3, 2026
@martpie martpie force-pushed the stylex branch 4 times, most recently from ed249a5 to c17ff59 Compare March 3, 2026 14:15
Base automatically changed from oxc to master March 4, 2026 01:47
@martpie martpie merged commit a40bb33 into master Mar 4, 2026
6 checks passed
@martpie martpie deleted the stylex branch March 4, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants