Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces StyleX into the Vite/React frontend and updates repo tooling/config (lint/format + CI/editor settings), alongside some formatting-only changes and updated Lingui translation reference lines.
Changes:
- Add StyleX (Vite plugin + StyleX runtime) and migrate
Buttonfrom CSS modules/classnames to StyleX. - Switch lint/format tooling to
oxlint/oxfmtand update CI + VS Code workspace recommendations/settings accordingly. - Reformat miscellaneous files and update
.posource references.
Reviewed changes
Copilot reviewed 21 out of 24 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Adds @stylexjs/unplugin Vite plugin to enable StyleX transforms. |
src/elements/Button.tsx |
Migrates styling from CSS modules to StyleX. |
package.json |
Adds StyleX + oxc tooling deps; updates lint/format scripts and metadata ordering. |
.oxlintrc.json |
Adds oxlint config, including StyleX ESLint rules via jsPlugins. |
.oxfmtrc.json |
Adds oxfmt formatting configuration. |
.github/workflows/build.yml |
Updates QA steps to run formatting + lint; adjusts matrix formatting. |
.vscode/settings.json / .vscode/extensions.json |
Switches editor integration from Biome to oxc/oxfmt. |
src/components/DropzoneImport.tsx |
Adjusts hook dependency array style. |
src/components/TrackList.tsx |
Refactors menu items builder usage; adjusts effect dependencies. |
src/hooks/useGlobalTrackListStatus.ts |
Adjusts effect dependency array style. |
src/routes/settings.library.tsx |
Adjusts callback dependency array style. |
src/__tests__/test-helpers.tsx |
Awaits render call (test harness). |
src/translations/*.po |
Updates source references; includes new/changed strings (but see review comments). |
index.html / README.md / src-tauri/Cargo.toml |
Formatting-only changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
90ca890 to
1ae4d02
Compare
ed249a5 to
c17ff59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I kinda like it.
This branch is based on
oxcasoxlintsupports ESLint JS rules, whichbiomecannot do :(Baseline: