Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the project's JavaScript runtime from npm/Node.js to Bun, while also including improvements to the TrackList component's layout structure.
Changes:
- Migrates build commands, documentation, and CI workflows from npm to Bun
- Enhances the Scrollable component to support optional custom className prop
- Restructures TrackListDefault component with improved flexbox layout for better scrolling behavior
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/translations/languages.ts | Updated comment to reference bun run instead of npm run |
| src/elements/Scrollable.tsx | Added optional className prop for style extensibility |
| src/components/TrackListDefault.tsx | Restructured with wrapper div and updated to use Scrollable's className prop |
| src/components/TrackListDefault.module.css | Added flex layout styles for root container and scroll area |
| src-tauri/tauri.conf.json | Updated build commands to use bun run and added schema reference |
| src-tauri/src/plugins/file_associations.rs | Updated test command comment to use bun run |
| package.json | Updated pre-commit hook to use Bun and added simple-git-hooks to trustedDependencies |
| README.md | Updated setup and development instructions to use Bun instead of Node.js/npm |
| .github/workflows/build.yml | Updated qa job to use Bun for setup and dependency installation |
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:40
- For consistency with the migration to Bun, consider replacing
npxwithbunxhere. Bun providesbunxas the equivalent ofnpxfor running packages. This would align with the rest of the PR's goal of migrating from npm to Bun.
run: npx playwright install chromium --with-deps
.github/workflows/build.yml:117
- The binaries job at line 92-94 still uses Node.js (actions/setup-node@v4) instead of Bun. For consistency with the migration to Bun, that section should also be updated to use oven-sh/setup-bun@v2. Currently, the qa job uses Bun while the binaries job uses Node.js, which creates an inconsistency in the build pipeline.
run: bun ci
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martpie
force-pushed
the
backbun
branch
3 times, most recently
from
2b952b0 to
3103e1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.