Make difftastic vendored rather than a cargo git dep#18
Merged
martinabeleda merged 3 commits intomainfrom Mar 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendor difftastic into
ripdiffso packaging no longer depends on an unpublished git-sourced library crate.What changed
src/difftastic/.src/vendored_parsers/.difftasticlibrary target inCargo.tomland wire inbuild.rsto compile the vendored parsers.martinabeleda/difftastic.vendor/difftastic/.Why
cargo packagestrips git dependencies during verification and resolves them fromcrates.io.ripdiffdepended on a fork ofdifftasticthat exposes a library API, but the publisheddifftasticcrate oncrates.iois not usable as a library dependency.Vendoring the modified difftastic code makes the crate self-contained and allows packaging and publish-style verification to succeed.
Verification
cargo checkenv CARGO_HOME=/tmp/ripdiff-cargo-home CARGO_TARGET_DIR=/tmp/ripdiff-package-target cargo package --allow-dirtyNotes
vendor/difftastic/VENDORED.mdpoints to the original upstream https://github.com/Wilfred/difftastic.