fix: use sys.executable instead of 'python' in end-to-end tests#27
Open
hai-pilgrim wants to merge 2 commits into
Open
fix: use sys.executable instead of 'python' in end-to-end tests#27hai-pilgrim wants to merge 2 commits into
hai-pilgrim wants to merge 2 commits into
Conversation
'python' is not always on PATH — many systems only have 'python3'. Four of five CLI tests were broken on any system without a 'python' symlink. Switch to sys.executable (the running interpreter) so the tests always invoke the correct Python binary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Pillow 12 deprecates Image.Image.getdata in favour of get_flattened_data (removal planned for Pillow 14). Update all five affected comparisons in test_end_to_end.py to silence DeprecationWarnings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pythonisn't on PATH (common on Linux where onlypython3exists)test_spritegrid_idempotencealready usedsys.executablecorrectly; the others did notsys.executableTest plan
pythonsymlinktest_spritegrid_idempotencebehavior unchanged (already usedsys.executable)🤖 Generated with Claude Code