Skip to content

feat(remark): inline mark highlighting, config system, and UX refinements #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liyuankui wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(remark): inline mark highlighting, config system, and UX refinements #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions chrome/src/popup/popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,50 @@ <h3 data-i18n="settings_auto_refresh_title">Auto Refresh</h3>
</div>
</div>

<div class="info-section">
<h3 data-i18n="remark_cfg_title">Remark Mode</h3>
<div style="margin: 10px 0;">
<label class="checkbox-label">
<input type="checkbox" id="remark-auto-delete-empty" checked>
<span data-i18n="remark_cfg_auto_delete">Auto-delete empty remarks</span>
</label>
</div>
<div style="margin: 10px 0;">
<label class="checkbox-label">
<input type="checkbox" id="remark-close-after-copy">
<span data-i18n="remark_cfg_close_after_copy">Close tab after copy</span>
</label>
</div>
<div style="margin: 10px 0;">
<label for="remark-highlight-style" data-i18n="remark_cfg_highlight_style">Highlight style</label>
<select id="remark-highlight-style">
<option value="background" data-i18n="remark_cfg_style_bg">Background</option>
<option value="underline" data-i18n="remark_cfg_style_underline">Underline</option>
<option value="wavy" data-i18n="remark_cfg_style_wavy">Wavy</option>
<option value="border" data-i18n="remark_cfg_style_border">Border</option>
</select>
</div>
<div style="margin: 10px 0;">
<label for="remark-default-color" data-i18n="remark_cfg_default_color">Default color</label>
<select id="remark-default-color">
<option value="yellow">🟡 Suggestion</option>
<option value="green">🟢 Keep</option>
<option value="blue">🔵 Question</option>
<option value="pink">🩷 Concern</option>
</select>
</div>
<div style="margin: 10px 0;">
<label for="remark-font-size" data-i18n="remark_cfg_font_size">Font size</label>
<select id="remark-font-size">
<option value="12">12px</option>
<option value="13" selected>13px</option>
<option value="14">14px</option>
<option value="15">15px</option>
<option value="16">16px</option>
</select>
</div>
</div>

<div class="info-section">
<h3 data-i18n="settings_cache_title">Cache</h3>
<div class="cache-stats" id="cache-stats">
Expand Down
64 changes: 64 additions & 0 deletions src/_locales/be/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,58 @@
"message": "Скасаваць і выдаліць",
"description": "Button text for cancelling a new remark and removing the temporary mark"
},
"remark_cfg_title": {
"message": "Рэжым анатацый",
"description": "Title for remark mode settings card"
},
"remark_cfg_auto_delete": {
"message": "Аўтавыдаленне пустых нататак",
"description": "Config: auto-delete annotations with no note"
},
"remark_cfg_close_after_copy": {
"message": "Закрыць укладку пасля капіявання",
"description": "Config: close the file tab after copying remarks"
},
"remark_cfg_default_color": {
"message": "Колер па змаўчанні",
"description": "Config: default annotation color"
},
"remark_cfg_done": {
"message": "Гатова",
"description": "Button to close config panel"
},
"remark_cfg_font_size": {
"message": "Памер шрыфту",
"description": "Config: sidebar font size"
},
"remark_cfg_highlight_style": {
"message": "Стыль вылучэння",
"description": "Config: how text is visually marked"
},
"remark_cfg_opacity": {
"message": "Непразрыстасць",
"description": "Config: highlight opacity"
},
"remark_cfg_reset": {
"message": "Скінуць налады",
"description": "Button to reset all config to defaults"
},
"remark_cfg_style_bg": {
"message": "Фон",
"description": "Highlight style: colored background"
},
"remark_cfg_style_border": {
"message": "Рамка",
"description": "Highlight style: bottom border"
},
"remark_cfg_style_underline": {
"message": "Падкрэсленне",
"description": "Highlight style: solid underline"
},
"remark_cfg_style_wavy": {
"message": "Хвалісты",
"description": "Highlight style: wavy underline"
},
"remark_change_color": {
"message": "Змяніць колер",
"description": "Tooltip for changing the remark color"
Expand Down Expand Up @@ -443,6 +495,10 @@
"message": "Націсніце, каб рэдагаваць",
"description": "Tooltip for editing an existing remark note"
},
"remark_empty": {
"message": "Вылучыце тэкст, каб дадаць нататку",
"description": "Placeholder shown in sidebar when no remarks exist"
},
"remark_empty_hint": {
"message": "Вылучыце тэкст, каб дадаць заўвагі",
"description": "Empty state hint in the remarks sidebar"
Expand All @@ -463,6 +519,14 @@
"message": "Рэжым заўваг",
"description": "Toolbar button title for entering remark mode"
},
"remark_save": {
"message": "Захаваць",
"description": "Save button in the annotation popup"
},
"remark_settings": {
"message": "Налады",
"description": "Settings button tooltip"
},
"remark_sidebar_title": {
"message": "Заўвагі",
"description": "Sidebar title for the remarks panel"
Expand Down
64 changes: 64 additions & 0 deletions src/_locales/da/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,58 @@
"message": "Annullér og fjern",
"description": "Button text for cancelling a new remark and removing the temporary mark"
},
"remark_cfg_title": {
"message": "Annotationstilstand",
"description": "Title for remark mode settings card"
},
"remark_cfg_auto_delete": {
"message": "Slet tomme noter automatisk",
"description": "Config: auto-delete annotations with no note"
},
"remark_cfg_close_after_copy": {
"message": "Luk fane efter kopiering",
"description": "Config: close the file tab after copying remarks"
},
"remark_cfg_default_color": {
"message": "Standardfarve",
"description": "Config: default annotation color"
},
"remark_cfg_done": {
"message": "Færdig",
"description": "Button to close config panel"
},
"remark_cfg_font_size": {
"message": "Skriftstørrelse",
"description": "Config: sidebar font size"
},
"remark_cfg_highlight_style": {
"message": "Fremhævningsstil",
"description": "Config: how text is visually marked"
},
"remark_cfg_opacity": {
"message": "Gennemsigtighed",
"description": "Config: highlight opacity"
},
"remark_cfg_reset": {
"message": "Nulstil til standard",
"description": "Button to reset all config to defaults"
},
"remark_cfg_style_bg": {
"message": "Baggrund",
"description": "Highlight style: colored background"
},
"remark_cfg_style_border": {
"message": "Ramme",
"description": "Highlight style: bottom border"
},
"remark_cfg_style_underline": {
"message": "Understreget",
"description": "Highlight style: solid underline"
},
"remark_cfg_style_wavy": {
"message": "Bølget",
"description": "Highlight style: wavy underline"
},
"remark_change_color": {
"message": "Skift farve",
"description": "Tooltip for changing the remark color"
Expand Down Expand Up @@ -443,6 +495,10 @@
"message": "Klik for at redigere",
"description": "Tooltip for editing an existing remark note"
},
"remark_empty": {
"message": "Vælg tekst for at tilføje noter",
"description": "Placeholder shown in sidebar when no remarks exist"
},
"remark_empty_hint": {
"message": "Vælg tekst for at tilføje kommentarer",
"description": "Empty state hint in the remarks sidebar"
Expand All @@ -463,6 +519,14 @@
"message": "Kommentar-tilstand",
"description": "Toolbar button title for entering remark mode"
},
"remark_save": {
"message": "Gem",
"description": "Save button in the annotation popup"
},
"remark_settings": {
"message": "Indstillinger",
"description": "Settings button tooltip"
},
"remark_sidebar_title": {
"message": "Kommentarer",
"description": "Sidebar title for the remarks panel"
Expand Down
64 changes: 64 additions & 0 deletions src/_locales/de/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,58 @@
"message": "Abbrechen und entfernen",
"description": "Cancel button in the annotation popup"
},
"remark_cfg_title": {
"message": "Anmerkungsmodus",
"description": "Title for remark mode settings card"
},
"remark_cfg_auto_delete": {
"message": "Leere Anmerkungen automatisch löschen",
"description": "Config: auto-delete annotations with no note"
},
"remark_cfg_close_after_copy": {
"message": "Tab nach dem Kopieren schließen",
"description": "Config: close the file tab after copying remarks"
},
"remark_cfg_default_color": {
"message": "Standardfarbe",
"description": "Config: default annotation color"
},
"remark_cfg_done": {
"message": "Fertig",
"description": "Button to close config panel"
},
"remark_cfg_font_size": {
"message": "Schriftgröße",
"description": "Config: sidebar font size"
},
"remark_cfg_highlight_style": {
"message": "Hervorhebungsstil",
"description": "Config: how text is visually marked"
},
"remark_cfg_opacity": {
"message": "Deckkraft",
"description": "Config: highlight opacity"
},
"remark_cfg_reset": {
"message": "Auf Standard zurücksetzen",
"description": "Button to reset all config to defaults"
},
"remark_cfg_style_bg": {
"message": "Hintergrund",
"description": "Highlight style: colored background"
},
"remark_cfg_style_border": {
"message": "Rahmen",
"description": "Highlight style: bottom border"
},
"remark_cfg_style_underline": {
"message": "Unterstrichen",
"description": "Highlight style: solid underline"
},
"remark_cfg_style_wavy": {
"message": "Wellig",
"description": "Highlight style: wavy underline"
},
"remark_change_color": {
"message": "Farbe ändern",
"description": "Tooltip for changing the remark color"
Expand Down Expand Up @@ -443,6 +495,10 @@
"message": "Klicken zum Bearbeiten",
"description": "Tooltip on a remark note in the sidebar indicating it is editable"
},
"remark_empty": {
"message": "Text auswählen, um Anmerkungen hinzuzufügen",
"description": "Placeholder shown in sidebar when no remarks exist"
},
"remark_empty_hint": {
"message": "Text auswählen, um Anmerkungen hinzuzufügen",
"description": "Empty state hint in the remarks sidebar"
Expand All @@ -463,6 +519,14 @@
"message": "Anmerkungsmodus",
"description": "Toolbar button tooltip to enter Remark Mode"
},
"remark_save": {
"message": "Speichern",
"description": "Save button in the annotation popup"
},
"remark_settings": {
"message": "Einstellungen",
"description": "Settings button tooltip"
},
"remark_sidebar_title": {
"message": "Anmerkungen",
"description": "Title of the Remark Mode sidebar panel"
Expand Down
Loading