fix:[#875] move output behind button#877
Open
jardon wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
i was able to get what im wanting with a debugger, but i havent been able to implement it yet in code. i set the
|
jardon
force-pushed
the
feat/view-output-box
branch
from
bff59a6 to
9f08c3f
Compare
Contributor
Author
|
i ended up just making the output box a height of 220. i dont like it, but the parent PdsActionPage is already fixed at 450 so this works. open to suggestions if someone knows a better way |
Owner
|
Thanks for the PR. I suggest showing the output button from the beginning. Otherwise, it would be hard to track the progress for long-running tasks like pulling images. |
jardon
force-pushed
the
feat/view-output-box
branch
from
9f08c3f to
9ea7ad4
Compare
- increase size of output box - hide output box behind "view output" button
jardon
force-pushed
the
feat/view-output-box
branch
from
9ea7ad4 to
bda5037
Compare
Contributor
Author
|
i reworked this to make it visible from the start. i also swapped the button order as when the pop up changed state, the view button would move causing misclicks |
Contributor
Author
|
@marhkb can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR hides the output of the command until the user presses, "view output". this allows a cleaner interface and also enables the action pop up to have a dedicated view for the output so that the viewbox can be bigger. here are some sample screen shots:
closes #875