Skip to content

Conversation

@marcoroth
Copy link
Owner

@marcoroth marcoroth commented Oct 25, 2025

CleanShot 2025-10-25 at 12 14 37@2x CleanShot 2025-10-25 at 12 10 17@2x

@marcoroth marcoroth changed the title Anotate Herb Labels with Render Times Annotate Herb Labels with Render Times Oct 25, 2025
@kozy4324
Copy link
Contributor

This looks like a really great feature — I’d definitely love to use it myself.
If there’s anything I can do to help, please feel free to let me know.

@kozy4324
Copy link
Contributor

Hi @marcoroth .

Following up on my previous comment — I actually spent some time experimenting with this locally.

I tried exploring whether a simpler approach could work, without introducing middleware. As one possible direction, I put together a small prototype on a branch here (there are a couple of commits in it):
https://github.com/kozy4324/reactionview/tree/render-times-and-queries-count

I’d be curious to hear your thoughts on this kind of approach.

While doing that, I also tried exposing the ActiveRecord query count alongside the rendering time, and it turned out to be surprisingly useful when profiling views.

image

This feels like a change that could make reactionview even more powerful overall, so if there’s anything I can help with — implementation, refinement, or testing — I’d be very happy to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants