Clean up regions, implemented most of region3 internal functions#9
Open
fritzmark wants to merge 7 commits into
Open
Clean up regions, implemented most of region3 internal functions#9fritzmark wants to merge 7 commits into
fritzmark wants to merge 7 commits into
Conversation
* Added region 3 internal implementation for internal energy * Documented region 3 inputs Region 3 is currently dependendent on density and temperature * Documented region 3 specific internal energy availability * Added specific entropy to region 3 * Added specific enthalpy to region 3 * Fixed typo in entropy * Added specific isochoric heat capacity to region 3 Albeit with tests that still needs to be verified. * Added specific isobaric heat capacity to region 3 * Added speed of sound to region 3 * Cleaned up test output
Adjusted access rights for region_3
…mark/rusteam into region4_move_to_own_module
Region4 move to own module
Contributor
Author
|
Heho @marciorvneto, Any complains about this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.