-
Notifications
You must be signed in to change notification settings - Fork 9
Add self-contained Mermaid diagram support via Goldmark #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,255
−104
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
510e062
Initial plan
Copilot 4b20af2
Replace golang-commonmark with Goldmark and add Mermaid support
Copilot 6596ee5
Address code review feedback: improve regex check, remove dead code, …
Copilot ae93570
Add mermaid.min.js to repository for offline self-contained rendering
Copilot b76b7c0
Move CDN regex to package level and make it more flexible
Copilot b28555a
Simplify embedMermaidScript and make regex more flexible
Copilot 5600c5b
Fix CDN script loading - use NoScript option and embed mermaid.js pro…
Copilot cbd660a
Fix script escaping to include closing bracket and improve comments
Copilot bf878a6
Improve mermaid diagram styling and README documentation
mapitman 70b9953
Update main.go
mapitman f6663a5
Update main.go
mapitman 9ae9445
Update main.go
mapitman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,13 @@ | ||
| module github.com/mapitman/mdview | ||
|
|
||
| go 1.21.1 | ||
| go 1.24 | ||
|
|
||
| toolchain go1.24.11 | ||
|
|
||
| require ( | ||
| github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c | ||
| gitlab.com/golang-commonmark/markdown v0.0.0-20211110145824-bf3e522c626a | ||
| github.com/yuin/goldmark v1.7.13 | ||
| go.abhg.dev/goldmark/mermaid v0.6.0 | ||
| ) | ||
|
|
||
| require ( | ||
| gitlab.com/golang-commonmark/html v0.0.0-20191124015941-a22733972181 // indirect | ||
| gitlab.com/golang-commonmark/linkify v0.0.0-20191026162114-a0c2df6c8f82 // indirect | ||
| gitlab.com/golang-commonmark/mdurl v0.0.0-20191124015652-932350d1cb84 // indirect | ||
| gitlab.com/golang-commonmark/puny v0.0.0-20191124015043-9f83538fa04f // indirect | ||
| golang.org/x/sys v0.1.0 // indirect | ||
| golang.org/x/text v0.3.8 // indirect | ||
| ) | ||
| require golang.org/x/sys v0.34.0 // indirect |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are duplicate changelog entries for "n.n.n / 2026-01-18" with identical content (lines 137-147 and 149-159). This creates redundancy in the changelog and should be consolidated into a single entry.