Feat: parallelize#3
Open
Murray2015 wants to merge 3 commits into
Open
Conversation
added 3 commits
May 3, 2024 20:21
…eers can work on the codebase. Kept defaults in main so it should keep working for Evangelos locally without changes
…ore I added this code. But I spot some complaining about mutating data in a dataframe copy, so possible one of the downloaders is mutating the geodataframe. Might be fine or might not be, needs investigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Evangelos. I've had a play with your code and got parallelization working. This PR does the following:
main(because otherwise, only your laptop can run this code).main, so that main can be called by other users. This is optional and defaults to all your hardcoded paths, which now live inmain. However, if you want to call it via the command line, it can be called like so:python main.py --geojson_dir geojson_files --log_dir logs --output_path output/. This is different to the makefile approach, which doesn't play nicely with the command line for passing file paths.