Fix npm release tarball publishing#32
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow and documentation to ensure npm publishes the generated release tarball reliably by using an explicit relative path (./...), and bumps the package version for the release.
Changes:
- Bump package version from
4.5.1to4.5.2(and syncpackage-lock.json). - Update
npm publishtarball paths inRELEASE.mdto use./release-artifacts/.... - Update the GitHub Actions
npm publishstep to publish./$tarballinstead of$tarball.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
RELEASE.md |
Updates documented npm publish commands to use an explicit ./-prefixed tarball path. |
package.json |
Version bump to 4.5.2. |
package-lock.json |
Lockfile version fields updated to match 4.5.2. |
.github/workflows/npm-release.yml |
Publishes the tarball using npm publish "./$tarball" ... for path robustness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor version bump to the package and updates the
npm publishcommands to use a relative path with a leading./for the tarball file. This change ensures that the publish commands are more robust and compatible with npm's expected file path format.Most important changes:
Version bump:
package.json: Bumped the package version from4.5.1to4.5.2.Documentation updates:
RELEASE.md: Updated allnpm publishcommands to use./release-artifacts/arcade-engine-X.Y.Z.tgzinstead ofrelease-artifacts/arcade-engine-X.Y.Z.tgz. [1] [2]Workflow update:
.github/workflows/npm-release.yml: Changed the publish step to use./$tarballinstead of$tarballfor the file path.