Skip to content

Bot zone-only whispering#251

Merged
billy1arm merged 3 commits intomangoszero:masterfrom
bozimmerman:bot_zoneonely_whisper
Mar 5, 2026
Merged

Bot zone-only whispering#251
billy1arm merged 3 commits intomangoszero:masterfrom
bozimmerman:bot_zoneonely_whisper

Conversation

@bozimmerman
Copy link
Contributor

@bozimmerman bozimmerman commented Mar 4, 2026

This is completely a matter of taste, but I did not appreciate bots in other zones asking me if they can join me for questing. It's silly.

This introduces a configuration value to limit bot whispers to those only in your same zone.


This change is Reviewable

Copilot AI review requested due to automatic review settings March 4, 2026 21:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Playerbot AI configuration option to restrict “suggestion” whisper spam so bots only whisper players in the same zone, reducing cross-zone solicitation.

Changes:

  • Introduced AiPlayerbot.WhisperToZoneOnly config option (default: false) and wired it into PlayerbotAIConfig.
  • Added a zone match gate in SuggestWhatToDoAction::spam() before sending whispers.
  • Documented the new config option in the distributed sample config.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/modules/Bots/playerbot/strategy/actions/SuggestWhatToDoAction.cpp Adds zone-only gating for suggestion whispers.
src/modules/Bots/playerbot/aiplayerbot.conf.dist.in Adds the new config key to the sample config.
src/modules/Bots/playerbot/PlayerbotAIConfig.h Declares new whisperToZoneOnly config field.
src/modules/Bots/playerbot/PlayerbotAIConfig.cpp Initializes and loads the new config value from aiplayerbot.conf.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AppVeyorBot
Copy link

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 4, 2026 23:58
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@billy1arm billy1arm merged commit a177769 into mangoszero:master Mar 5, 2026
7 of 8 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +81 to +82
# If enabled, bot suggestion whispers will only target players in the same zone
#AiPlayerbot.WhisperToZoneOnly = false
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this config template, boolean options are consistently shown as 0/1 (e.g., AiPlayerbot.Enabled = 1, #AiPlayerbot.AllowGuildBots = 1). Consider using 0/1 for WhisperToZoneOnly as well (or at least note accepted values) to keep the sample config consistent and avoid confusion for admins copy/pasting.

Suggested change
# If enabled, bot suggestion whispers will only target players in the same zone
#AiPlayerbot.WhisperToZoneOnly = false
# If enabled (set to 1), bot suggestion whispers will only target players in the same zone
#AiPlayerbot.WhisperToZoneOnly = 0

Copilot uses AI. Check for mistakes.
@AppVeyorBot
Copy link

@bozimmerman bozimmerman deleted the bot_zoneonely_whisper branch March 8, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants