Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Playerbot AI configuration option to restrict “suggestion” whisper spam so bots only whisper players in the same zone, reducing cross-zone solicitation.
Changes:
- Introduced
AiPlayerbot.WhisperToZoneOnlyconfig option (default:false) and wired it intoPlayerbotAIConfig. - Added a zone match gate in
SuggestWhatToDoAction::spam()before sending whispers. - Documented the new config option in the distributed sample config.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/modules/Bots/playerbot/strategy/actions/SuggestWhatToDoAction.cpp |
Adds zone-only gating for suggestion whispers. |
src/modules/Bots/playerbot/aiplayerbot.conf.dist.in |
Adds the new config key to the sample config. |
src/modules/Bots/playerbot/PlayerbotAIConfig.h |
Declares new whisperToZoneOnly config field. |
src/modules/Bots/playerbot/PlayerbotAIConfig.cpp |
Initializes and loads the new config value from aiplayerbot.conf. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| # If enabled, bot suggestion whispers will only target players in the same zone | ||
| #AiPlayerbot.WhisperToZoneOnly = false |
There was a problem hiding this comment.
In this config template, boolean options are consistently shown as 0/1 (e.g., AiPlayerbot.Enabled = 1, #AiPlayerbot.AllowGuildBots = 1). Consider using 0/1 for WhisperToZoneOnly as well (or at least note accepted values) to keep the sample config consistent and avoid confusion for admins copy/pasting.
| # If enabled, bot suggestion whispers will only target players in the same zone | |
| #AiPlayerbot.WhisperToZoneOnly = false | |
| # If enabled (set to 1), bot suggestion whispers will only target players in the same zone | |
| #AiPlayerbot.WhisperToZoneOnly = 0 |
This is completely a matter of taste, but I did not appreciate bots in other zones asking me if they can join me for questing. It's silly.
This introduces a configuration value to limit bot whispers to those only in your same zone.
This change is