chore(code-quality): resolve P2 code scanning alerts#810
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Suppress CodeQL false positives across 12 files with no behavioral changes: - Add `# type: ignore[empty-body]` to Protocol/ABC stubs (16 alerts) - Add suppression comments for side-effect imports (5 alerts) - Add file-level explanation to vulture_whitelist.py (2 alerts) - Rename unused test var `resp1` -> `_resp1`, add seed comments (5 alerts) - Remove unused `log` + `structlog` import from ingest/service.py (1 alert) - Add suppression comment for `await` in `contextlib.suppress()` (1 alert) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
force-pushed
the
chore/resolve-p2-code-scanning-alerts-805
branch
from
1496048 to
efa3c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# type: ignore[empty-body]to all Protocol and ABC stub methods (16 alerts acrossstorage.py,providers/__init__.py,events.py,ambient.py)alembic/env.py,llm_router.py)loglogger andstructlogimport fromingest/service.pytest_capture.py,test_wiki_service.py,test_conversation_fork.py)vulture_whitelist.pyCloses #805
Test plan
ruff checkpasses with no errorsruff format --checkpasses with no reformatting needed🤖 Generated with Claude Code