-
Notifications
You must be signed in to change notification settings - Fork 17
Version 3.4.12; updated SDK to .NET 10; added gitHub/agent instructions #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… is provided for the `gen -a path\` command.
…comparisons from older versions.
…lass TypeEnumValidator is no longer being generated!
…re error messages on test failure.
….System.DateTimeOnly and System.Memory nuget.
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net6.0;net5.0;netcoreapp3.1;netframework472</TargetFrameworks> | ||
| <TargetFrameworks>net10.0;net9.0;net8.0;net7.0;net6.0;net5.0;netcoreapp3.1;netframework472</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamift I don't think this is needed?
Normally you can run tools targeting earlier frameworks without issue on newer one?
Listing a framework explicitly should only be required if you intend on using a new framework-specific feature.
Having many targets needs more build passes (so longer) and bloats IDE memory, which tries to juggle available apis for all requested target framework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is only for the LinqToXsd tool project; XObjectsCore and XObjectsCodeGen still target just 2 framework monikers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is different about LinqToXsd tool? If it's built for net5.0 I can run it on my machine that has .net10.0, can't I?
Another drawback of this long list of target frameworks is that anyone who works on LinqToXsd source needs to have all these targeting packs installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another drawback of this long list of target frameworks is that anyone who works on LinqToXsd source needs to have all these targeting packs installed
No they don't. I've only got .NET 6, 8, and 10 SDK installed. Only .NET 8 and 10 runtimes and am able to build it all fine. Also the build server I use only uses the .NET 10 SDK and runtime and it's able to produce assets for all TFMs without issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not SDKs, targeting packs.
You can have just .NET 10 SDK and build for all targets listed here, but you need targeting packs.
At least for .net framework versions... now that I look into it, targeting packs don't seem to exists for .net core, makes me wonder how it works.
But I still don't get why so many targets are needed? If you target net5.0 (and build with .net 10 SDK), it should run just fine on a machine that has .net 10 runtime?
…e Generate() method was checking for configs if they were XSD v1.1 and not the actual XSD schema file.
…simple type unions. Defaulted to system.object.
…ous simple union types.
…mple types and unions.
…e a name for a simple type union type.
d04efd2 to
c79f35d
Compare
Updated to version 3.4.12
gen -a path\command.This is a release that fixes exactly one CLI bug and adds more test for quality assurance for future releases.
Also addresses #67