Skip to content

add: support for GCS related values #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pratapalakshmi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add: support for GCS related values #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a76f75c
add: support for GCS related values
pratapalakshmi May 14, 2026
eecc127
fix: minio and gcs configurations
pratapalakshmi May 14, 2026
ddb3df6
add APP_BASE_URL in api-app-vars
pratapalakshmi May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/plane-enterprise/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Meet Plane. An Enterprise software development tool to manage issue

type: application

version: 2.4.1
version: 2.4.2
appVersion: "2.5.4"
home: https://plane.so/
icon: https://plane.so/favicon/favicon-32x32.png
Expand Down
8 changes: 8 additions & 0 deletions charts/plane-enterprise/templates/config-secrets/app-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ data:
WEB_URL: "http://{{ .Values.license.licenseDomain }}"
{{- end }}

{{- if .Values.env.app_base_url}}
APP_BASE_URL: {{ .Values.env.app_base_url | default "" | quote }}
{{- else if or .Values.ssl.tls_secret_name (and .Values.ssl.createIssuer .Values.ssl.generateCerts) }}
APP_BASE_URL: "https://{{ .Values.license.licenseDomain }}"
{{- else }}
APP_BASE_URL: "http://{{ .Values.license.licenseDomain }}"
{{- end }}

LIVE_BASE_URL: "http://{{ .Release.Name }}-live.{{ .Release.Namespace }}.svc.cluster.local:3000/"
LIVE_BASE_PATH: "/live"
{{- if or .Values.ssl.tls_secret_name (and .Values.ssl.createIssuer .Values.ssl.generateCerts) }}
Expand Down
20 changes: 19 additions & 1 deletion charts/plane-enterprise/templates/config-secrets/doc-store.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{{- if empty .Values.external_secrets.doc_store_existingSecret }}
{{- $storageProvider := .Values.env.storage_provider | default "s3" }}
apiVersion: v1
kind: Secret
type: Opaque
Expand All @@ -8,7 +9,7 @@ metadata:
stringData:
FILE_SIZE_LIMIT: {{ .Values.env.file_size_limit | default "5242880" | quote }}
AWS_S3_BUCKET_NAME: {{ .Values.env.docstore_bucket | default "" | quote }}
{{- if .Values.services.minio.local_setup }}
{{- if and (eq $storageProvider "s3") .Values.services.minio.local_setup }}
USE_MINIO: "1"
MINIO_ROOT_USER: {{ .Values.services.minio.root_user | default "admin" | quote }}
MINIO_ROOT_PASSWORD: {{ .Values.services.minio.root_password | default "password" | quote}}
Expand All @@ -22,5 +23,22 @@ stringData:
AWS_REGION: {{ .Values.env.aws_region | default "" | quote }}
AWS_S3_ENDPOINT_URL: {{ .Values.env.aws_s3_endpoint_url | quote }}
{{- end }}

STORAGE_PROVIDER: {{ $storageProvider | quote }}
SIGNED_URL_EXPIRATION: {{ .Values.env.signed_url_expiration | default 3600 | quote }}
{{- if eq $storageProvider "gcs" }}
{{- if and (empty .Values.env.gcs_credentials_path) (empty .Values.env.gcs_credentials_json) }}
{{- fail "either env.gcs_credentials_path or env.gcs_credentials_json is required when env.storage_provider is 'gcs'" }}
{{- end }}
GCS_BUCKET_NAME: {{ required "env.gcs_bucket_name is required when env.storage_provider is 'gcs'" .Values.env.gcs_bucket_name | quote }}
GCS_PROJECT_ID: {{ required "env.gcs_project_id is required when env.storage_provider is 'gcs'" .Values.env.gcs_project_id | quote }}
GCS_CREDENTIALS_JSON: {{ .Values.env.gcs_credentials_json | default "" | quote }}
GCS_CREDENTIALS_PATH: {{ .Values.env.gcs_credentials_path | default "" | quote }}
{{- else }}
GCS_BUCKET_NAME: {{ .Values.env.gcs_bucket_name | default "" | quote }}
GCS_PROJECT_ID: {{ .Values.env.gcs_project_id | default "" | quote }}
GCS_CREDENTIALS_JSON: {{ .Values.env.gcs_credentials_json | default "" | quote }}
GCS_CREDENTIALS_PATH: {{ .Values.env.gcs_credentials_path | default "" | quote }}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
{{- end }}
{{- end }}
---
11 changes: 11 additions & 0 deletions charts/plane-enterprise/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,16 @@ env:
aws_region: ''
aws_s3_endpoint_url: ''

# STORAGE PROVIDER SELECTION (s3 or gcs)
storage_provider: 's3'
signed_url_expiration: 3600

# GCS (REQUIRED IF storage_provider IS 'gcs')
gcs_bucket_name: ''
gcs_project_id: ''
gcs_credentials_json: ''
gcs_credentials_path: ''

use_storage_proxy: false
allow_all_attachment_types: false
enable_drf_spectacular: false
Expand All @@ -493,6 +503,7 @@ env:
cors_allowed_origins: ''
instance_admin_email: ''
web_url: ''
app_base_url: ''

live_sentry_dsn: ""
live_sentry_environment: ""
Expand Down