fix: Corrected lack of optional parameters for creating multiple mailing list members#444
Open
leovietro wants to merge 1 commit into
Open
fix: Corrected lack of optional parameters for creating multiple mailing list members#444leovietro wants to merge 1 commit into
leovietro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I encountered an issue while integrating this SDK into our project. Our mailing lists only store email addresses and ignore the other optional parameters defined in the
CreateUpdateMailListMemberstype:However, the
IMailListsMembers.createMembersmethod requires themembersparameter to use theMailListMembertype, which mandates all properties:Our temporary workaround was to cast the parameter to
any, but we don't like that :PTo resolve this cleanly, I created a new type for
IMailListsMembers.createMembersthat makes these properties optional. Although I considered using the existingCreateUpdateMailListMemberswithOmit<>to remove theupsertfield, a new type looks clearer and simpler for casting: