fix: remove version commit step from release workflow (#809)#810
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| - name: Install dependencies | ||
| if: ${{ steps.release.outputs.release_created }} | ||
| run: bun install | ||
| - name: Sync package versions | ||
| if: ${{ steps.release.outputs.release_created }} | ||
| run: bun run sync-version | ||
| - name: Commit synced versions | ||
| if: ${{ steps.release.outputs.release_created }} | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| if [[ -n "$(git status --porcelain)" ]]; then | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
| git add projects/campfire-vscode-extension/package.json apps/campfire/package.json | ||
| git commit -m "chore: sync release versions" | ||
| git push | ||
| else | ||
| echo "No version changes detected" | ||
| fi | ||
| - name: Build Format | ||
| if: ${{ steps.release.outputs.release_created }} | ||
| run: bun run build |
There was a problem hiding this comment.
The release job no longer runs sync-version or commits its results before bun run build. Only the root package.json is touched by release‑please; apps/campfire/package.json and projects/campfire-vscode-extension/package.json are not. After this change, every release will tag the new root version while those subpackages remain at the previous version in main, and future builds will dirty the working tree when bun run build updates them locally. That leaves the repository in a permanently inconsistent state and breaks bun run check-version until someone manually commits the synced files. Consider retaining a step that syncs and pushes subpackage version bumps, or teach release‑please to update those files in the PR.
Useful? React with 👍 / 👎.
1 participant
No description provided.