fix: preserve editor state in shared URLs#1222
Open
uv05709 wants to merge 1 commit into
Open
Conversation
…nk instead of base64
|
@uv05709 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @uv05709Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @uv05709!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Author
|
Hi maintainers! I’ve updated the PR title to follow Conventional Commits and verified the changes locally. The workflows currently show “Action required” and may need approval for forked PR execution. I’ve also attached the screen recording. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical frontend/UX issue where the "Copy Link" feature generated a stateless URL that discarded all active editor settings when shared.
The editor state is now serialized into URL query parameters so shared links preserve the current editing configuration.
Changes Included
EditRecipesettings into URL query paramsExample Shared URL
Restored Settings
Related Issue
Closes #1219
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link: Add your Loom/screen recording link here
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in