Skip to content

fix: preserve editor state in shared URLs#1222

Open
uv05709 wants to merge 1 commit into
magic-peach:mainfrom
uv05709:main
Open

fix: preserve editor state in shared URLs#1222
uv05709 wants to merge 1 commit into
magic-peach:mainfrom
uv05709:main

Conversation

@uv05709
Copy link
Copy Markdown

@uv05709 uv05709 commented May 26, 2026

Description

This PR fixes a critical frontend/UX issue where the "Copy Link" feature generated a stateless URL that discarded all active editor settings when shared.

The editor state is now serialized into URL query parameters so shared links preserve the current editing configuration.

Changes Included

  • Serialized EditRecipe settings into URL query params
  • Restored editor state from URL params on page load
  • Added success feedback/toast after copying the link
  • Preserved privacy-first behavior by excluding the actual video file
  • Improved shareability and reproducibility of edits

Example Shared URL

https://reframe-lilac.vercel.app/?preset=cinematic&speed=1.5&rotate=90&mute=true

Restored Settings

  • preset
  • framing
  • trimStart
  • trimEnd
  • speed
  • rotation
  • crf
  • mute

Related Issue

Closes #1219

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: @uv05709
  • Contribution level (Beginner/Intermediate/Advanced): Intermediate

Screen Recording

Recording / Loom link: Add your Loom/screen recording link here

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

@uv05709 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

✅ PR Format Check Passed — @uv05709

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @uv05709!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:performance Performance type:refactor Code refactor gssoc'26 GirlScript Summer of Code 2026 labels May 26, 2026
@uv05709 uv05709 changed the title Fix #1219: Serialize state to URL query params for copy link instead … fix: preserve editor state in shared URLs May 26, 2026
@uv05709
Copy link
Copy Markdown
Author

uv05709 commented May 26, 2026

Hi maintainers! I’ve updated the PR title to follow Conventional Commits and verified the changes locally. The workflows currently show “Action required” and may need approval for forked PR execution. I’ve also attached the screen recording. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:performance Performance type:refactor Code refactor

Projects

None yet

1 participant