fix(preview): Fix for Video Cropping Preview Issue #1191
Open
mrdeyroy wants to merge 1 commit into
Open
Conversation
…each#1184) Fixes the bug where VideoPreview and ComparisonPreview incorrectly cropped videos due to misaligned overlay calculations. Replaced the manual math overlay with a dynamic CSS output frame using object-fit to accurately mirror the FFmpeg export behavior.
|
@mrdeyroy is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @mrdeyroyBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:advanced
Contributor
👋 Thanks for your PR, @mrdeyroy!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Author
|
@magic-peach Whenever you get time review this PR ! thanks... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolved an issue where
VideoPreviewandComparisonPreviewwere incorrectly calculating framing overlay percentages resulting in misleading video previews. Replaced the manual math overlay logic with a dynamic CSS output frame utilizingobject-fit: cover(Fill) andobject-fit: contain(Fit) to accurately mirror the underlying FFmpeg scaling behavior natively.overlaycoordinate states.DraggableTextOverlayscalculates positional coordinates based on the new output frame boundaries.Related Issue
Closes #1184
Type of Contribution
Participant Info
Screen Shot
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in