feat(trim): Add Video Trimming Support with Start and End Selection (#993)#1188
Open
Rucha0901 wants to merge 9 commits into
Open
feat(trim): Add Video Trimming Support with Start and End Selection (#993)#1188Rucha0901 wants to merge 9 commits into
Rucha0901 wants to merge 9 commits into
Conversation
…ng and playhead sync (magic-peach#1074)
…eydown handlers and ARIA attributes
…esolve stale preview dimensions (magic-peach#1075)
…al-time seeking and playback looping
|
@Rucha0901 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Rucha0901!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Rucha0901Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
Author
|
@magic-peach ,check the PR . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds high-fidelity, interactive Video Trimming Support with Start and End Selection (#993). Users can now visually select custom start and end points via a timeline-based dual-handle slider overlaying their audio waveform, preview their trimmed cuts frame-by-frame in real-time, and automatically loop playback within their selected region before exporting.
Key Enhancements:
TrimControl.tsxwith a visual track containing drag handles, dark background masks for trimmed-out regions, and a neon highlight for the selected clip.WaveformCanvasas a gorgeous background for the timeline slider.currentTimeandseekTofromuseVideoEditorand passed them intoTrimControl. Dragging the handles instantly seeks the player to the selected frame, and a vertical red playhead tracks active playback.VideoPreview.tsxto automatically loop playback inside the selection bounds (trimStarttotrimEnd) during active play, while allowing standard frame inspection when paused.ArrowLeft/ArrowRight) to nudge selection handles by0.1seconds.Related Issue
Closes #993
Type of Contribution
Participant Info
Screen Recording
Demonstrated full visual range selection, drag-to-seek, keyboard adjustments, and playback boundary loop enforcement.
Recording / Loom link: [Attached in system capture]
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in