feat: Add Captions/Subtitles Support with Custom Styling Options #991#1187
Open
Rucha0901 wants to merge 8 commits into
Open
feat: Add Captions/Subtitles Support with Custom Styling Options #991#1187Rucha0901 wants to merge 8 commits into
Rucha0901 wants to merge 8 commits into
Conversation
…ng and playhead sync (magic-peach#1074)
…eydown handlers and ARIA attributes
…esolve stale preview dimensions (magic-peach#1075)
|
@Rucha0901 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @Rucha0901!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @Rucha0901Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
Author
|
@magic-peach ,check the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds complete support for uploading, previewing, and burning in captions/subtitles from
.srtfiles directly within Reframe..srtparser (src/lib/subtitles.ts) supporting time range parsing, multi-line blocks, and alternative punctuation.SubtitleControls.tsxfor Font Family, text color, scale size, and background style presets.paintOrderstyling to avoid fill bleed), Translucent Background Box, and Drop Shadow.drawtextfilters withenable='between(t, start, end)'inside the backgroundffmpeg.worker.tsWeb Worker during export. This avoids WebAssembly-vf subtitlescore crashes and guarantees offline burn-in reliability.Related Issue
Closes #991
Type of Contribution