fix: resolve hydration mismatches on initial load#1161
Open
aspartic-gthb wants to merge 1 commit into
Open
Conversation
- Added mounted state to ThemeToggle to render placeholder during SSR - Added suppressHydrationWarning to FileUpload DropZone for extension injections - Added localStorage polyfill in vitest.setup.ts to fix failing test suite
|
@aspartic-gthb is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @aspartic-gthb!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @aspartic-gthbBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:beginner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two hydration mismatches that occur on the initial page load, and fixes a failing test in the suite:
mountedstate toThemeToggleto render a neutral placeholder during SSR, preventing aria-label attribute mismatch.suppressHydrationWarningto theFileUploadDropZone to handle third-party browser extensions (like FormDin) that inject thefdprocessedidattribute.localStoragemock polyfill invitest.setup.tsto fix theTypeError: localStorage.clear is not a functionerror in theThemeToggle.test.tsxtest.Related Issue
Fixes #1154
Type of Contribution
Participant Info
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in