fix: resolve hydration mismatches in ThemeToggle and FileUpload components#1155
Open
compiler041 wants to merge 1 commit into
Open
fix: resolve hydration mismatches in ThemeToggle and FileUpload components#1155compiler041 wants to merge 1 commit into
compiler041 wants to merge 1 commit into
Conversation
|
@compiler041 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Contributor
👋 Thanks for your PR, @compiler041!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes hydration mismatch errors caused by theme-dependent rendering and
browser extension attribute injection.
Closes #[paste issue number here]
Changes
src/components/ThemeToggle.tsxmountedstate initialized tofalseuseEffectto setmounted = trueafter hydrationserver and client HTML match exactly
opacity-0to prevent layout shiftsrc/components/FileUpload.tsxsuppressHydrationWarningto the DropZone inner divinjecting
fdprocessedidattributesRoot Cause
useTheme()returns theme state that depends onlocalStorage, whichis unavailable during SSR. This causes the server to render with a
default theme while the client renders with the stored preference.
Testing