fix: avoid conflict with double quote within data#233
Open
aleen42 wants to merge 1 commit intomafintosh:masterfrom
Open
fix: avoid conflict with double quote within data#233aleen42 wants to merge 1 commit intomafintosh:masterfrom
aleen42 wants to merge 1 commit intomafintosh:masterfrom
Conversation
jcapcik
reviewed
Jan 16, 2024
jcapcik
left a comment
There was a problem hiding this comment.
I was also looking for a way to account for quotes within an unquoted field, which some other parsers seem to handle just fine (Excel and Rainbow CSV being a few).
This change breaks stuff in a lot of situations though. However, it lead me to a slight change that seems to work at least in my current set of tests.
Instead of checking if i === 1, which is not correct since i is the zero-based index of the character in the entire file, not each line, check if i === start, which would indicate the start of the line:
const isStartingQuote = !isQuoted && buffer[i] === quote && (i === start || buffer[i - 1] === comma)
So we only consider a quote a starting quote if we aren't within quotes already, and it either is the first character of the line or it follows a comma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Strictly define what a stating quote is except for the case like that: